[Remote state] Integrate remote cluster state in publish/commit flow #9665

soosinha · 2023-08-31T11:16:52Z

Description

Follow up PR for : #9160
In the above PR, RemotePersistedState and RemoteClusterStateService were created. In the current PR, these classes are integrated into the cluster state publish flow. The upload of cluster metadata will happen just before the cluster state publish request is sent to all nodes

Related Issues

#9338

Previous PR in forked repo: soosinha#3

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-08-31T11:22:20Z

Compatibility status:

Checks if related components are compatible with change 198b091

Incompatible components

Skipped components

Compatible components

github-actions · 2023-08-31T11:23:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/23966/
CommitID: 198b091
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

shwetathareja

still going through, publishing initial comments

server/src/main/java/org/opensearch/cluster/coordination/CoordinationState.java

server/src/main/java/org/opensearch/cluster/coordination/Coordinator.java

server/src/main/java/org/opensearch/node/Node.java

github-actions · 2023-08-31T12:39:56Z

Compatibility status:

Checks if related components are compatible with change ce7c21a

Incompatible components

Skipped components

Compatible components

github-actions · 2023-08-31T13:14:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.index.shard.RemoteIndexShardTests.testNRTReplicaWithRemoteStorePromotedAsPrimaryRefreshCommit

URL: https://build.ci.opensearch.org/job/gradle-check/23973/
CommitID: ce7c21a
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-08-31T13:15:58Z

Codecov Report

Merging #9665 (8729c72) into main (079c3e9) will increase coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 82.85%.

@@             Coverage Diff              @@
##               main    #9665      +/-   ##
============================================
+ Coverage     71.09%   71.18%   +0.08%     
- Complexity    57743    57800      +57     
============================================
  Files          4806     4807       +1     
  Lines        272202   272245      +43     
  Branches      39723    39730       +7     
============================================
+ Hits         193531   193801     +270     
+ Misses        62413    62177     -236     
- Partials      16258    16267       +9

Files Changed	Coverage Δ
...java/org/opensearch/discovery/DiscoveryModule.java	`90.27% <ø> (ø)`
server/src/main/java/org/opensearch/node/Node.java	`85.52% <53.84%> (-0.59%)`	⬇️
...arch/gateway/remote/RemoteClusterStateService.java	`78.62% <83.33%> (+0.14%)`	⬆️
.../java/org/opensearch/gateway/GatewayMetaState.java	`67.32% <85.71%> (+1.55%)`	⬆️
...search/cluster/coordination/CoordinationState.java	`88.39% <90.90%> (-0.22%)`	⬇️
...h/cluster/coordination/PersistedStateRegistry.java	`91.66% <91.66%> (ø)`
...g/opensearch/cluster/coordination/Coordinator.java	`78.41% <100.00%> (-0.10%)`	⬇️

... and 453 files with indirect coverage changes

linuxpi

One minor comment, Otherwise LGTM.

Also, please fix DCO and precommit checks

github-actions · 2023-09-02T16:51:53Z

Compatibility status:

Checks if related components are compatible with change 81e1a24

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Signed-off-by: Sooraj Sinha <[email protected]>

github-actions · 2023-09-02T17:01:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseAllShards

URL: https://build.ci.opensearch.org/job/gradle-check/24240/
CommitID: 81e1a24
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-09-02T17:42:05Z

Compatibility status:

Checks if related components are compatible with change 2311dd7

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

github-actions · 2023-09-02T17:53:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/24243/
CommitID: 2311dd7

shwetathareja

Minor comment, rest looks good @soosinha

server/src/test/java/org/opensearch/cluster/coordination/CoordinationStateTests.java

server/src/main/java/org/opensearch/node/Node.java

github-actions · 2023-09-04T02:12:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/24292/
CommitID: 379010a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Sooraj Sinha <[email protected]>

github-actions · 2023-09-04T02:31:16Z

Compatibility status:

Checks if related components are compatible with change 379010a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

github-actions · 2023-09-04T02:49:38Z

Compatibility status:

Checks if related components are compatible with change 8729c72

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

github-actions · 2023-09-04T03:03:01Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/24293/
CommitID: 8729c72

opensearch-trigger-bot · 2023-09-04T09:30:06Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9665-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d375e4cfea1a8e4c58dd1409365a67cf49366780
# Push it to GitHub
git push --set-upstream origin backport/backport-9665-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9665-to-2.x.

…pensearch-project#9665) * Integrate remote cluster state in publish/commit flow Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit d375e4c)

…9665) (#9751) * Integrate remote cluster state in publish/commit flow Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit d375e4c)

…pensearch-project#9665) * Integrate remote cluster state in publish/commit flow Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>

…pensearch-project#9665) * Integrate remote cluster state in publish/commit flow Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>

…pensearch-project#9665) * Integrate remote cluster state in publish/commit flow Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

shwetathareja reviewed Aug 31, 2023

View reviewed changes

linuxpi approved these changes Sep 2, 2023

View reviewed changes

soosinha force-pushed the remote_state_integrate branch from 5a1c2d2 to 81e1a24 Compare September 2, 2023 16:19

Add assertions and modify unit tests for remote state

2311dd7

Signed-off-by: Sooraj Sinha <[email protected]>

soosinha force-pushed the remote_state_integrate branch from 81e1a24 to 2311dd7 Compare September 2, 2023 17:02

shwetathareja reviewed Sep 3, 2023

View reviewed changes

server/src/test/java/org/opensearch/cluster/coordination/CoordinationStateTests.java Outdated Show resolved Hide resolved

server/src/main/java/org/opensearch/node/Node.java Show resolved Hide resolved

Modify CoordinationStateTests

8729c72

Signed-off-by: Sooraj Sinha <[email protected]>

soosinha force-pushed the remote_state_integrate branch from 379010a to 8729c72 Compare September 4, 2023 02:14

shwetathareja approved these changes Sep 4, 2023

View reviewed changes

shwetathareja merged commit d375e4c into opensearch-project:main Sep 4, 2023

shwetathareja added the backport 2.x Backport to 2.x branch label Sep 4, 2023

opensearch-trigger-bot bot added the backport-failed label Sep 4, 2023

soosinha mentioned this pull request Sep 5, 2023

[Remote state] Integrate remote cluster state in publish/commit flow (#9665) #9751

Merged

This was referenced Sep 12, 2023

[Remote Store] Initial upload after bootstrap #9339

Closed

[Remote State] Add commit info to remote store when cluster state publish to quorum #9340

Closed

soosinha deleted the remote_state_integrate branch December 20, 2024 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Remote state] Integrate remote cluster state in publish/commit flow #9665

[Remote state] Integrate remote cluster state in publish/commit flow #9665

soosinha commented Aug 31, 2023 •

edited

Loading

github-actions bot commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

shwetathareja left a comment

github-actions bot commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

codecov bot commented Aug 31, 2023 •

edited

Loading

linuxpi left a comment •

edited

Loading

github-actions bot commented Sep 2, 2023

github-actions bot commented Sep 2, 2023

github-actions bot commented Sep 2, 2023

github-actions bot commented Sep 2, 2023

shwetathareja left a comment

github-actions bot commented Sep 4, 2023

github-actions bot commented Sep 4, 2023

github-actions bot commented Sep 4, 2023

github-actions bot commented Sep 4, 2023

opensearch-trigger-bot bot commented Sep 4, 2023

[Remote state] Integrate remote cluster state in publish/commit flow #9665

[Remote state] Integrate remote cluster state in publish/commit flow #9665

Conversation

soosinha commented Aug 31, 2023 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Aug 31, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Aug 31, 2023

Gradle Check (Jenkins) Run Completed with:

shwetathareja left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 31, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Aug 31, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Aug 31, 2023 • edited Loading

Codecov Report

linuxpi left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 2, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 2, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 2, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 2, 2023

Gradle Check (Jenkins) Run Completed with:

shwetathareja left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 4, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 4, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 4, 2023

Gradle Check (Jenkins) Run Completed with:

opensearch-trigger-bot bot commented Sep 4, 2023

soosinha commented Aug 31, 2023 •

edited

Loading

codecov bot commented Aug 31, 2023 •

edited

Loading

linuxpi left a comment •

edited

Loading