add logging for remote monitor execution flows #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
requested review from
lezzago,
AWSHurneyt,
sbcd90,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn,
jowg-amazon,
amsiglan and
goyamegh
as code owners
jowg-amazon
reviewed
Oct 2, 2024
| @@ -49,7 +49,7 @@ open class RemoteMonitorRunner { | |||
| } | |||
|
|
|||
| open fun getFanOutAction(): String { | |||
| return DocLevelMonitorFanOutAction.NAME | |||
| throw UnsupportedOperationException("Fan out action needs to be implemented by remote monitor."); | |||
There was a problem hiding this comment.
Why is this being thrown as an exception now instead of returning the name?
There was a problem hiding this comment.
this class needs to be implemented and registered at
public Map<String, RemoteMonitorRunner> getMonitorTypesToMonitorRunners() in Plugin
should not have a default fan out action. needs to be specified by the new monitor created by extending this class
jowg-amazon
approved these changes
Oct 2, 2024
sbcd90
approved these changes
Oct 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit ba3e715) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit ba3e715) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit ba3e715) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 2, 2024
eirsep
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit ba3e715) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit ba3e715) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit ba3e715) Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add logging for remote monitor execution flows