Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Alerting to 2.0 #354

Closed
wants to merge 11 commits into from
Closed

Upgrade Alerting to 2.0 #354

wants to merge 11 commits into from

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Mar 21, 2022

Issue #, if available:
#313 - OpenSearch 2.0 Upgrade
#325 - Remove JDK 8 support
#351 - Fix issue by upgrading to 2.0
Description of changes:

  • Build Alerting for OS 2.0
  • Security integ test fails due to this issue

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago lezzago marked this pull request as ready for review March 21, 2022 19:18
@lezzago lezzago requested a review from a team March 21, 2022 19:18
@lezzago lezzago changed the title Lezzago 2.0 dev2 Upgrade Alerting to 2.0 Mar 21, 2022
Copy link
Member

@getsaurabh02 getsaurabh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR is also upgrading Kotlin and gradle version along with the 2.0 version upgrade, the number of files touched/changed are huge. I will recommend to see if we can break it down to incremental changes such as Kotlin upgrade first, followed by the 2.0 version.
Just a suggestion and not necessarily a blocker.

@lezzago lezzago closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants