-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving over data models from alerting to common-utils #556
Conversation
Signed-off-by: Subhobrata Dey <[email protected]>
the whitesource scan failure is a known issue & it will be fixed by |
Signed-off-by: Subhobrata Dey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbcd90. LGTM. Lets link the follow up refactoring issue with this PR where we would be making the Monitor leaner and will move back some of the implementations back to Alerting.
done. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-556-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f34ee220426994b0811f526890d26d2f960a3586
# Push it to GitHub
git push --set-upstream origin backport/backport-556-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
* Added 2.1 release notes. (#485) (#487) * Added 2.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 9f3c393) Co-authored-by: AWSHurneyt <[email protected]> * Staging for version increment automation (#489) (#503) * Version increment automation Signed-off-by: pgodithi <[email protected]> * Version increment automation: task rename updateVersion Signed-off-by: pgodithi <[email protected]> (cherry picked from commit 3b8bfe7) Signed-off-by: prudhvigodithi <[email protected]> Co-authored-by: Prudhvi Godithi <[email protected]> * Add support for reproducible builds (#472) (#499) As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <[email protected]> (cherry picked from commit a27d5a2) Signed-off-by: prudhvigodithi <[email protected]> Co-authored-by: Leonidas Spyropoulos <[email protected]> * Refactored backwards compatibility tests to point to the OpenSearch 1.1.0.0 zip following deprecation of ODFE. (#510) (#512) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit fea6b4a) Co-authored-by: AWSHurneyt <[email protected]> * Bumping 2.x branch version from 2.1.0 to 2.2.0. Bumped mockito-core version from 4.3.1 to 4.6.1. (#506) Signed-off-by: AWSHurneyt <[email protected]> * Added 2.2 release notes. (#514) * Added 2.2 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.2 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Bumped 2.x branch from version 2.2.0 to 2.3.0. (#547) * Bumped 2.x branch from version 2.2.0 to 2.3.0. Signed-off-by: AWSHurneyt <[email protected]> * Bumped mockito core version. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Deprecate the Master nomenclature (#548) (#549) Signed-off-by: Subhobrata Dey <[email protected]> * Added 2.3 release notes. (#551) * Added 2.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * moving over data models from alerting to common-utils (#556) Signed-off-by: Subhobrata Dey <[email protected]> * backport monitor datasources to 2.x (#558) Signed-off-by: Surya Sashank Nistala <[email protected]> * expose delete monitor api from alerting (#568) Signed-off-by: Subhobrata Dey <[email protected]> * Use findings and alerts models, dtos from common utils (#569) Signed-off-by: Surya Sashank Nistala <[email protected]> * Disable ktlint for alerting as it has errors on Windows (#570) (#571) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 3a844f8) Co-authored-by: Peter Zhu <[email protected]> * Recreate request object from writeable for Get alerts and get findings (#577) Signed-off-by: Surya Sashank Nistala <[email protected]> * Use alerting models and dtos from common-utils dependencies Signed-off-by: Surya Sashank Nistala <[email protected]> * port over datasources alert index usage correctly Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: AWSHurneyt <[email protected]> Co-authored-by: Prudhvi Godithi <[email protected]> Co-authored-by: Leonidas Spyropoulos <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Signed-off-by: Subhobrata Dey [email protected]
Description of changes:
moving over data models from alerting to common-utils
Follow-up for this PR: opensearch-project/common-utils#236
CheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.