-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to specify backend roles for monitors #635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <[email protected]>
qreshi
reviewed
Nov 2, 2022
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt
Show resolved
Hide resolved
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
============================================
- Coverage 76.37% 76.00% -0.38%
Complexity 116 116
============================================
Files 124 124
Lines 6443 6485 +42
Branches 942 956 +14
============================================
+ Hits 4921 4929 +8
- Misses 1040 1069 +29
- Partials 482 487 +5 ☔ View full report in Codecov by Sentry. |
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Ashish Agrawal <[email protected]>
rishabhmaurya
approved these changes
Nov 3, 2022
brijos
changed the title
Support specificy backend roles for monitors
Support to specify backend roles for monitors
Nov 3, 2022
Signed-off-by: Ashish Agrawal <[email protected]>
rishabhmaurya
approved these changes
Nov 4, 2022
qreshi
reviewed
Nov 4, 2022
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Ashish Agrawal <[email protected]>
qreshi
approved these changes
Nov 4, 2022
4 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
* Support specify backend roles for monitors Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit f986238)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
* Support specify backend roles for monitors Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit f986238)
lezzago
added a commit
that referenced
this pull request
Nov 4, 2022
* Support specify backend roles for monitors Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit f986238) Co-authored-by: Ashish Agrawal <[email protected]>
lezzago
added a commit
that referenced
this pull request
Nov 4, 2022
* Support specify backend roles for monitors Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit f986238) Co-authored-by: Ashish Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Agrawal [email protected]
Issue #, if available:
#138
Description of changes:
Support specify backend roles for monitors
New Scenarios:
Create monitor scenario:
Update monitor scenario:
Empty list is considered as removing all permissions the user has access to or create a monitor with no backend roles
Throw exceptions if a user tries to associate roles that they do not have access to
Only admin users can pass in an empty list. Non-admin users need to pass in at least 1 backend role so they dont remove their access from the monitor for mistakes
Example of new create/update monitor request (
rbac_roles
is the new optional parameter):CheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.