Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code coverage badge #171

Merged
merged 2 commits into from
May 16, 2022
Merged

add code coverage badge #171

merged 2 commits into from
May 16, 2022

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented May 10, 2022

Description

This PR enables jacoco test coverage report generation & subsequent upload of report to codecov.

Issues Resolved

Add code coverage badge to README.md, .codecov.yml with require_ci_to_pass: yes

Check List

  • New functionality includes testing.
    • [X ] All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <[email protected]>
@sbcd90 sbcd90 requested a review from a team May 10, 2022 01:28
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@389bb3c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage        ?   83.80%           
  Complexity      ?      434           
=======================================
  Files           ?       66           
  Lines           ?     2204           
  Branches        ?      254           
=======================================
  Hits            ?     1847           
  Misses          ?      260           
  Partials        ?       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389bb3c...c750431. Read the comment docs.

Signed-off-by: Subhobrata Dey <[email protected]>
@dblock
Copy link
Member

dblock commented May 16, 2022

Looking at the note from codecov above I don't think that's running in this project. I would fix that first.

@sbcd90
Copy link
Collaborator Author

sbcd90 commented May 16, 2022

@dblock this pr enables uploading reports to codecov also. merging this pr should run codecov for the project.
currently only pr generated report got uploaded

Copy link
Member

@getsaurabh02 getsaurabh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a possibility to have broken this into 2 separate PRs for clarity.

@sbcd90 sbcd90 merged commit 4557ed1 into opensearch-project:main May 16, 2022
zelinh pushed a commit that referenced this pull request Aug 18, 2022
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants