Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] remove https only restrictions on webhook url protocols #43

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Jul 31, 2021

Description

remove https only restrictions on webhook url protocols
notificatuion side change is made in this PR opensearch-project/notifications#248

Issues Resolved

opensearch-project/notifications#232

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zhongnansu zhongnansu marked this pull request as ready for review July 31, 2021 18:41
@zhongnansu zhongnansu changed the title [Notification] remove restrictions on webhook url protocols to also include http [Notification] remove https only restrictions on webhook url protocols Jul 31, 2021
@zhongnansu zhongnansu requested a review from joshuali925 August 2, 2021 17:08
@zhongnansu zhongnansu merged commit 0af72bf into opensearch-project:main Aug 2, 2021
zelinh pushed a commit that referenced this pull request Aug 18, 2022
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants