-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Changes required for snapshot missing in 1.1 #63
Conversation
Signed-off-by: Vacha <[email protected]>
run: ./gradlew publishToMavenLocal -Dbuild.snapshot=false | ||
run: ./gradlew publishToMavenLocal | ||
|
||
# common-utils | ||
- name: Build and Test | ||
run: | | ||
./gradlew build -Dopensearch.version=1.1.0 | ||
./gradlew build -Dopensearch.version=1.1.0-SNAPSHOT | ||
|
||
- name: Publish to Maven Local | ||
run: | | ||
./gradlew publishToMavenLocal -Dopensearch.version=1.1.0 | ||
./gradlew publishToMavenLocal -Dopensearch.version=1.1.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we add all the snapshots back?
@@ -12,7 +12,7 @@ | |||
buildscript { | |||
ext { | |||
opensearch_group = "org.opensearch" | |||
opensearch_version = System.getProperty("opensearch.version", "1.1.0") | |||
opensearch_version = System.getProperty("opensearch.version", "1.1.0-SNAPSHOT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same snapshots
ext { | ||
isSnapshot = "true" == System.getProperty("build.snapshot", "true") | ||
} | ||
|
||
allprojects { | ||
group 'org.opensearch.commons' | ||
version = opensearch_version - '-SNAPSHOT' + '.0' | ||
if (isSnapshot) { | ||
version += "-SNAPSHOT" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same Why do we add all the snapshots back?
@peterzhuamazon I did not make any code changes, just merged the 2 snapshot related PRs from main into this branch, if we need to have a branch specific change I'll need someone from common-util to take the lead |
@VachaShah Can you take a look? |
We should merge everything in main -> 1.x. |
I am going to leave this up to the branch owners to migrate |
Description
Backporting all changes from main onto branch 1.1
Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.