Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.3.4. #444

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jul 7, 2022

Signed-off-by: Zelin Hao [email protected]

Description

Increment version to 1.3.4

Issues Resolved

Part of opensearch-project/opensearch-build#2205

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team July 7, 2022 21:51
@saikaranam-amazon
Copy link
Member

we are dependent on common-utils and building is failing as artifacts are not yet published for 1.3.4

Could not determine the dependencies of task ':thirdPartyAudit'.
> Could not resolve all files for configuration ':runtimeClasspath'.
   > Could not resolve org.opensearch:common-utils:1.3.4.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve org.opensearch:common-utils:1.3.4.0-SNAPSHOT.
         > Could not get resource 'https://plugins.gradle.org/m2/org/opensearch/common-utils/1.3.4.0-SNAPSHOT/common-utils-1.3.4.0-SNAPSHOT.pom'.
            > Could not GET 'https://repo.gradle.org/artifactory/jcenter/org/opensearch/common-utils/1.3.4.0-SNAPSHOT/common-utils-1.3.4.0-SNAPSHOT.pom'. Received status code 409 from server: Conflict

@zelinh
Copy link
Member Author

zelinh commented Jul 8, 2022

We should be having the common-utils snapshot now. Please help re-run the checks. Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #444 (bd40149) into 1.3 (9d764d2) will decrease coverage by 1.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #444      +/-   ##
============================================
- Coverage     73.81%   72.44%   -1.37%     
+ Complexity      927      914      -13     
============================================
  Files           139      139              
  Lines          4464     4464              
  Branches        527      527              
============================================
- Hits           3295     3234      -61     
- Misses          853      913      +60     
- Partials        316      317       +1     
Impacted Files Coverage Δ
...ication/action/setup/TransportSetupChecksAction.kt 58.62% <0.00%> (-13.80%) ⬇️
...ch/replication/task/index/IndexReplicationState.kt 48.33% <0.00%> (-13.34%) ⬇️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 80.00% <0.00%> (-11.67%) ⬇️
...tion/repository/RemoteClusterMultiChunkTransfer.kt 70.73% <0.00%> (-9.76%) ⬇️
.../replication/metadata/store/ReplicationMetadata.kt 75.32% <0.00%> (-6.50%) ⬇️
...action/stop/TransportStopIndexReplicationAction.kt 64.38% <0.00%> (-5.48%) ⬇️
...ication/action/stop/StopIndexReplicationRequest.kt 57.89% <0.00%> (-5.27%) ⬇️
...ion/action/resume/ResumeIndexReplicationRequest.kt 57.89% <0.00%> (-5.27%) ⬇️
...tlin/org/opensearch/replication/util/Extensions.kt 67.07% <0.00%> (-4.88%) ⬇️
...arch/replication/task/autofollow/AutoFollowTask.kt 67.80% <0.00%> (-4.80%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d764d2...bd40149. Read the comment docs.

@saikaranam-amazon
Copy link
Member

saikaranam-amazon commented Jul 11, 2022

Security tests are failing as security plugin is not loading (unrelated to CCR changes) and might need separate follow-up with security plugin team :

at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) [netty-common-4.1.78.Final.jar:4.1.78.Final]
»  	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [netty-common-4.1.78.Final.jar:4.1.78.Final]
»  	at java.lang.Thread.run(Thread.java:829) [?:?]
» ERROR][o.o.ExceptionsHelper     ] [leaderCluster-0] fatal error
»  	at org.opensearch.ExceptionsHelper.lambda$maybeDieOnAnotherThread$4(ExceptionsHelper.java:310)
»  	at java.base/java.util.Optional.ifPresent(Optional.java:183)
»  	at org.opensearch.ExceptionsHelper.maybeDieOnAnotherThread(ExceptionsHelper.java:300)
»  	at org.opensearch.http.netty4.Netty4HttpServerTransport$HttpChannelHandler.exceptionCaught(Netty4HttpServerTransport.java:368)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:302)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:281)
»  	at io.netty.channel.AbstractChannelHandlerContext.fireExceptionCaught(AbstractChannelHandlerContext.java:273)
»  	at io.netty.channel.DefaultChannelPipeline$HeadContext.exceptionCaught(DefaultChannelPipeline.java:1377)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:302)
»  	at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:281)
»  	at io.netty.channel.DefaultChannelPipeline.fireExceptionCaught(DefaultChannelPipeline.java:907)
»  	at io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:627)
»  	at io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:181)
»  	at io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:152)
»  	at org.opensearch.security.ssl.http.netty.SecuritySSLNettyHttpServerTransport$SSLHttpChannelHandler.initChannel(SecuritySSLNettyHttpServerTransport.java:84)
»  	at io.netty.channel.ChannelInitializer.initChannel(ChannelInitializer.java:129)
»  	at io.netty.channel.ChannelInitializer.handlerAdded(ChannelInitializer.java:112)
»  	at io.netty.channel.AbstractChannelHandlerContext.callHandlerAdded(AbstractChannelHandlerContext.java:938)
»  	at io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:609)
»  	at io.netty.channel.

and for whitesource opened PR: #448

@saikaranam-amazon saikaranam-amazon merged commit 31833db into opensearch-project:1.3 Jul 11, 2022
@saikaranam-amazon
Copy link
Member

security plugin load issue tracked in : opensearch-project/security#1934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants