Remove org.opensearch.secure_sm.ThreadPermission from plugin manifest, this permission should not be granted #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, this permission should not be granted Signed-off-by: Andriy Redko <[email protected]>
reta
commented
May 30, 2024
| @@ -12,5 +12,4 @@ grant codeBase "${codebase.zstd-jni}" { | |||
|
|
|||
| grant codeBase "${codebase.qat-java}" { | |||
| permission java.lang.RuntimePermission "loadLibrary.*"; | |||
| permission org.opensearch.secure_sm.ThreadPermission "modifyArbitraryThread"; | |||
There was a problem hiding this comment.
@mulugetam I missed that in the original pull request, why you added this permission? It should not be granted.
sarthakaggarwal97
approved these changes
May 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2024
…, this permission should not be granted (#151) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 95d04e5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
thanks @reta for this! |
sarthakaggarwal97
pushed a commit
that referenced
this pull request
May 30, 2024
…, this permission should not be granted (#151) (#152) (cherry picked from commit 95d04e5) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove org.opensearch.secure_sm.ThreadPermission from plugin manifest, this permission should not be granted
Issues Resolved
Followup on #122
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.