Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes to support mds in getSeverFeatures API #205

Merged
merged 3 commits into from
May 22, 2024

Conversation

riysaxen-amzn
Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn commented May 21, 2024

Description

This PR fixes the bug in MDS support for Notifications. Changes introduced:

  • The issue is getSeverFeatures API should take the dataSourceId to return the response as per the provided dataSource
  • getServerFeatures API should be called whenever a component updates to update the states as per the dataSource
  • Also, removes some unused import from public/components/MDSEnabledComponent/MDSEnabledComponent.tsx

Issues Resolved

getSeverFeatures API call to support MDS is fixed

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@riysaxen-amzn riysaxen-amzn marked this pull request as ready for review May 21, 2024 17:44
@riysaxen-amzn riysaxen-amzn changed the title Bug fixes mds Bug fixes to support mds in getSeverFeatures API May 21, 2024
Signed-off-by: Riya Saxena <[email protected]>
@sbcd90 sbcd90 merged commit fbfe849 into opensearch-project:main May 22, 2024
6 of 7 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-205-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fbfe8493f2bc706390e313aea02963b7690fd0bf
# Push it to GitHub
git push --set-upstream origin backport/backport-205-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-205-to-2.x.

riysaxen-amzn added a commit to riysaxen-amzn/dashboards-notifications that referenced this pull request Jun 10, 2024
@riysaxen-amzn riysaxen-amzn mentioned this pull request Jun 10, 2024
1 task
amsiglan pushed a commit that referenced this pull request Jun 10, 2024
* bumping up the opensearch dashboards versions

Signed-off-by: Riya Saxena <[email protected]>

* manual backport of #205

Signed-off-by: Riya Saxena <[email protected]>

* Update opensearch_dashboards.json

Signed-off-by: Riya <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants