Page header #236
Merged
Page header #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riysaxen-amzn
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
* added release notes 2.16 Signed-off-by: Riya Saxena <[email protected]> * added release notes for 2.16 Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
force-pushed
the
page-header
branch
from
80e7f98 to
d48f441
Compare
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
AWSHurneyt
approved these changes
Aug 16, 2024
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
amsiglan
reviewed
Aug 19, 2024
amsiglan
reviewed
Aug 19, 2024
amsiglan
reviewed
Aug 19, 2024
Signed-off-by: Riya Saxena <[email protected]>
amsiglan
reviewed
Aug 19, 2024
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
amsiglan
reviewed
Aug 20, 2024
amsiglan
reviewed
Aug 20, 2024
amsiglan
reviewed
Aug 20, 2024
amsiglan
reviewed
Aug 20, 2024
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
amsiglan
reviewed
Aug 20, 2024
Signed-off-by: Riya Saxena <[email protected]>
amsiglan
reviewed
Aug 20, 2024
Comment on lines
308
to
313
| <PageHeader | ||
| appRightControls={headerControls} | ||
| appLeftControls={[ | ||
| { renderComponent: totalEmailGroups }, | ||
| ]} | ||
| /> |
There was a problem hiding this comment.
This shouldn't go inside the action, instead be outside the ContentPanel
amsiglan
approved these changes
Aug 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
* added release notes 2.16 (#227) * added release notes 2.16 Signed-off-by: Riya Saxena <[email protected]> * added release notes for 2.16 Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> * chanels complete Signed-off-by: Riya Saxena <[email protected]> * almost done Signed-off-by: Riya Saxena <[email protected]> * corrected Chanel list page Signed-off-by: Riya Saxena <[email protected]> * view channel Signed-off-by: Riya Saxena <[email protected]> * view channel Signed-off-by: Riya Saxena <[email protected]> * channel details fixed Signed-off-by: Riya Saxena <[email protected]> * fixed many things Signed-off-by: Riya Saxena <[email protected]> * bug fixes Signed-off-by: Riya Saxena <[email protected]> * fix tests page header changes Signed-off-by: Riya Saxena <[email protected]> * code refactored Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * Compressed UX Signed-off-by: Riya Saxena <[email protected]> * resolve merge conflict from main Signed-off-by: Riya Saxena <[email protected]> * resolve merge conflict from main Signed-off-by: Riya Saxena <[email protected]> * refactored the code Signed-off-by: Riya Saxena <[email protected]> * refactored the code Signed-off-by: Riya Saxena <[email protected]> * addressed the comment Signed-off-by: Riya Saxena <[email protected]> * addressed the comment Signed-off-by: Riya Saxena <[email protected]> * addressed the comment Signed-off-by: Riya Saxena <[email protected]> * addressed the comment Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 33d7bc1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Aug 20, 2024
* added release notes 2.16 (#227) * added release notes 2.16 * added release notes for 2.16 --------- * chanels complete * almost done * corrected Chanel list page * view channel * view channel * channel details fixed * fixed many things * bug fixes * fix tests page header changes * code refactored * fix UTs * Compressed UX * resolve merge conflict from main * resolve merge conflict from main * refactored the code * refactored the code * addressed the comment * addressed the comment * addressed the comment * addressed the comment --------- (cherry picked from commit 33d7bc1) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Page-header changes as per new UX
Issues Resolved
recording.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.