addressed comments for undefined variables

Signed-off-by: sumukhswamy <[email protected]>
opensearch-project · Aug 12, 2024 · 39545a4 · 39545a4
1 parent 16d20ef
commit 39545a4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 13 deletions.
diff --git a/public/components/integrations/components/added_integration_table.tsx b/public/components/integrations/components/added_integration_table.tsx
@@ -145,8 +145,6 @@ export function AddedIntegrationsTable(props: AddedIntegrationsTableProps) {
     ),
   ].sort();
 
-  console.log(mdsLabels);
-
   const search = {
     box: {
       incremental: true,

diff --git a/public/components/integrations/components/setup_integration.tsx b/public/components/integrations/components/setup_integration.tsx
@@ -51,10 +51,7 @@ export interface IntegrationConfigProps {
   dataSourceEnabled: boolean;
   dataSourceManagement: DataSourceManagementPluginSetup;
   savedObjectsMDSClient: SavedObjectsStart;
-  handleSelectedDataSourceChange: (
-    dataSourceMDSId: string | undefined,
-    dataSourceMDSLabel: string | undefined
-  ) => void;
+  handleSelectedDataSourceChange: (dataSourceMDSId?: string, dataSourceMDSLabel?: string) => void;
 }
 
 type SetupCallout = { show: true; title: string; color?: Color; text?: string } | { show: false };
@@ -426,7 +423,7 @@ export function SetupIntegrationForm({
   const updateConfig = (updates: Partial<IntegrationSetupInputs>) =>
     setConfig(Object.assign({}, integConfig, updates));
 
-  const handleSelectedDataSourceChange = (id: string | undefined, label: string | undefined) => {
+  const handleSelectedDataSourceChange = (id?: string, label?: string) => {
     setDataSourceMDSId(id);
     setDataSourceMDSLabel(label);
   };

diff --git a/public/components/integrations/components/setup_integration_inputs.tsx b/public/components/integrations/components/setup_integration_inputs.tsx
@@ -211,10 +211,7 @@ export function IntegrationConnectionInputs({
   dataSourceEnabled: boolean;
   dataSourceManagement: DataSourceManagementPluginSetup;
   savedObjectsMDSClient: SavedObjectsStart;
-  handleSelectedDataSourceChange: (
-    dataSourceMDSId: string | undefined,
-    dataSourceMDSLabel: string | undefined
-  ) => void;
+  handleSelectedDataSourceChange: (dataSourceMDSId?: string, dataSourceMDSLabel?: string) => void;
   lockConnectionType?: boolean;
 }) {
   const [dataSourceMDSId, setDataSourceMDSId] = useState<string | undefined>('');

diff --git a/server/adaptors/integrations/integrations_manager.ts b/server/adaptors/integrations/integrations_manager.ts
@@ -157,8 +157,8 @@ export class IntegrationsManager {
     templateName: string,
     name: string,
     indexPattern: string,
-    dataSourceMDSId: string | undefined,
-    dataSourceMDSLabel: string | undefined,
+    dataSourceMDSId?: string,
+    dataSourceMDSLabel?: string,
     workflows?: string[],
     dataSource?: string,
     tableName?: string