[navigation]feat: remove useless registration of Notebook to analytics nav group #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
|
It would be better that we can get this fix merged to 2.x. Maintainers please help to add backport 2.x label. |
7 tasks
TackAdam
approved these changes
Aug 8, 2024
|
@TackAdam No, it should still sit under |
derek-ho
approved these changes
Aug 8, 2024
SuZhou-Joe
changed the title
mengweieric
approved these changes
Aug 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit df6266a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Aug 8, 2024
TackAdam
pushed a commit
to TackAdam/dashboards-observability
that referenced
this pull request
Aug 20, 2024
Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notebook is registered under analytics nav group by accident, this PR is to fix that. Notebook will still be visible under observability nav group.
Before fix
After fix
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.