[Bug fix] Traces/Services bugfixes and UI update #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Oct 25, 2024
ps48
reviewed
Oct 25, 2024
public/components/trace_analytics/components/traces/traces_content.tsx
Outdated
Show resolved
Hide resolved
ps48
reviewed
Oct 25, 2024
public/components/trace_analytics/components/services/services_content.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Tackett <[email protected]>
ps48
approved these changes
Oct 25, 2024
paulstn
approved these changes
Oct 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* Bugfixes and ui update Signed-off-by: Adam Tackett <[email protected]> * address comments Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 39bb832) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
that referenced
this pull request
Oct 29, 2024
* Bugfixes and ui update * address comments --------- (cherry picked from commit 39bb832) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug Fixes:
1. Allow clicking the actions button in pop out to close so it does not get stuck open.
2. Fix the filtering problem switching between traces and services by setting the session storage mode.
3. Fix the redirection in new navigation for clicking on the trace column.
UI Updates
1. Move the actions button to no longer overlap the close button.
2. Rework the filter button to mimic the properties of dashboards discover.
3. Adjust spacing for conditional new filter line after one is added.
Video for trace column redirection
New navigation:
NewNavigation.mov
Old navigation:
OldNavigation.mov
Filters working:
FiltersWorking.mov
UI changes:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.