Use savedObjects client to fetch notebook visualizations #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
reviewed
Nov 4, 2024
public/components/notebooks/components/paragraph_components/paragraphs.tsx
Outdated
Show resolved
Hide resolved
public/components/notebooks/components/paragraph_components/paragraphs.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
approved these changes
Nov 5, 2024
paulstn
approved these changes
Nov 5, 2024
TackAdam
approved these changes
Nov 6, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2241-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e52e1de17b999461e572b395572f95f17f4cdef
# Push it to GitHub
git push --set-upstream origin backport/backport-2241-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.xThen, create a pull request where the |
ps48
added a commit
to ps48/dashboards-observability
that referenced
this pull request
Nov 7, 2024
…project#2241) * Use savedObjects client to fetch notebook visualizations Signed-off-by: Shenoy Pratik <[email protected]> * resolve comments Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 1e52e1d)
6 tasks
ps48
added a commit
that referenced
this pull request
Nov 7, 2024
* Use savedObjects client to fetch notebook visualizations Signed-off-by: Shenoy Pratik <[email protected]> * resolve comments Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 1e52e1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use savedObjects client to fetch notebook visualizations
Issues Resolved
Notebooks visualizations API was calling the local cluster to fetch savedobjects with MDS enabled. But when the savedObjects are not stored in
.kibanaindex, they routes lead to 404/400. Hence, updating the client to use the one provided by OSD core. This automatically takes care of switching between the saved object source.notebooks-visualization-fix.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.