-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Update UI and handle new navigation #416
Conversation
Signed-off-by: Adam Tackett <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 71.05% 71.13% +0.07%
==========================================
Files 31 31
Lines 2011 2016 +5
Branches 432 434 +2
==========================================
+ Hits 1429 1434 +5
Misses 579 579
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
public/components/report_definitions/create/create_report_definition.tsx
Outdated
Show resolved
Hide resolved
public/components/main/report_definition_details/report_definition_details.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
Signed-off-by: Adam Tackett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking thanks for taking this up
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.x
# Create a new branch
git switch --create backport/backport-416-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20dea69a6f58b2a4038b0ebb7c43e5314d745a1b
# Push it to GitHub
git push --set-upstream origin backport/backport-416-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.17
# Create a new branch
git switch --create backport/backport-416-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 20dea69a6f58b2a4038b0ebb7c43e5314d745a1b
# Push it to GitHub
git push --set-upstream origin backport/backport-416-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.17 Then, create a pull request where the |
* update reporting UI and handle new navigation Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix spacing from comment Signed-off-by: Adam Tackett <[email protected]> * fix comments Signed-off-by: Adam Tackett <[email protected]> * fix lint spacing in app Signed-off-by: Adam Tackett <[email protected]> * more lint Signed-off-by: Adam Tackett <[email protected]> * and more lint Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 20dea69)
* update reporting UI and handle new navigation Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix spacing from comment Signed-off-by: Adam Tackett <[email protected]> * fix comments Signed-off-by: Adam Tackett <[email protected]> * fix lint spacing in app Signed-off-by: Adam Tackett <[email protected]> * more lint Signed-off-by: Adam Tackett <[email protected]> * and more lint Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 20dea69)
) * [Bugfix] Update UI and handle new navigation (#416) * update reporting UI and handle new navigation Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix spacing from comment Signed-off-by: Adam Tackett <[email protected]> * fix comments Signed-off-by: Adam Tackett <[email protected]> * fix lint spacing in app Signed-off-by: Adam Tackett <[email protected]> * more lint Signed-off-by: Adam Tackett <[email protected]> * and more lint Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 20dea69) * small button and update snapshots Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]>
* [Bugfix] Update UI and handle new navigation (#416) * update reporting UI and handle new navigation Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix linting errors Signed-off-by: Adam Tackett <[email protected]> * fix spacing from comment Signed-off-by: Adam Tackett <[email protected]> * fix comments Signed-off-by: Adam Tackett <[email protected]> * fix lint spacing in app Signed-off-by: Adam Tackett <[email protected]> * more lint Signed-off-by: Adam Tackett <[email protected]> * and more lint Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 20dea69) * switch to small button Signed-off-by: Adam Tackett <[email protected]> * update snapshots Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]>
Description
New navigation
Old Navigation
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.