Change dompurify version to 3.0.11 to match OSD #516
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritvi Bhatt <[email protected]>
ps48
approved these changes
Feb 4, 2025
rishabh6788
reviewed
Feb 4, 2025
| @@ -2512,7 +2512,7 @@ dompurify@^2.2.0: | |||
| resolved "https://registry.yarnpkg.com/dompurify/-/dompurify-2.5.6.tgz#8402b501611eaa7fb3786072297fcbe2787f8592" | |||
| integrity sha512-zUTaUBO8pY4+iJMPE1B9XlO2tXVYIcEA4SNGtvDELzTSCQO7RzH+j7S180BmhmJId78lqGU2z19vgVx2Sxs/PQ== | |||
|
|
|||
| dompurify@^3.2.4: | |||
| dompurify@^3.0.11: | |||
| version "3.2.4" | |||
There was a problem hiding this comment.
shouldn't the version field be updated automatically to 3.1.6 like in OSD?
@ritvibhatt @ps48
There was a problem hiding this comment.
I've tried bootstrapping without the --single-version=loose flag and that version difference isn't causing any errors
There was a problem hiding this comment.
Please bootstrap without the flag like we do it in jenkins build.
There was a problem hiding this comment.
yes without the flag, it's not showing an error with this change
There was a problem hiding this comment.
we can actually remove dompurify here and use the one from core, since core also depends on dompurify now
joshuali925
approved these changes
Feb 4, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> (cherry picked from commit 9fa0467) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> (cherry picked from commit 9fa0467) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Feb 4, 2025
(cherry picked from commit 9fa0467) Signed-off-by: Ritvi Bhatt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ritvi Bhatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change dompurify version to 3.0.11 to match OSD
Different versions are causing build issues
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.