Handling end to end acknowledgement in Jira Source #5344
Merged
+125
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
san81
requested review from
sb2k16,
chenqi0805,
engechas,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
...ler/src/main/java/org/opensearch/dataprepper/plugins/source/source_crawler/base/Crawler.java
Show resolved
Hide resolved
...ra-source/src/main/java/org/opensearch/dataprepper/plugins/source/jira/JiraSourceConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santhosh Gandhe <[email protected]>
oeyh
reviewed
Jan 23, 2025
.../src/main/java/org/opensearch/dataprepper/plugins/source/jira/rest/auth/JiraOauthConfig.java
Outdated
Show resolved
Hide resolved
...search/dataprepper/plugins/source/source_crawler/coordination/scheduler/WorkerScheduler.java
Show resolved
Hide resolved
Signed-off-by: Santhosh Gandhe <[email protected]>
oeyh
approved these changes
Jan 23, 2025
sb2k16
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the end to end Acknowledgment handling in the common code i.e. source-crawler (instead of just in Jira source) so that it will be available for any future sources that we add.
This PR also has some minor clean up on the OAuthConfig class.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.