Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait for node param to Cluster Health #599

Merged
merged 4 commits into from
May 23, 2022

Conversation

Naarcha-AWS
Copy link
Collaborator

Fixes #552

Makes edits to PR #553.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

lukas-vlcek and others added 4 commits May 4, 2022 16:22
…T API

Additional improvements:

- The master_timeout is marked as deprecated and cluster_manager_timeout is suggested instead
- A required permissions is also documented
- The JSON example response is completed

Closes: #552
Signed-off-by: Lukáš Vlček <[email protected]>
@Naarcha-AWS Naarcha-AWS added the 3 - Tech review PR: Tech review in progress label May 23, 2022
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner May 23, 2022 17:55
@Naarcha-AWS Naarcha-AWS self-assigned this May 23, 2022
@Naarcha-AWS
Copy link
Collaborator Author

Naarcha-AWS commented May 23, 2022

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels May 23, 2022
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naarcha-AWS Naarcha-AWS assigned natebower and unassigned Naarcha-AWS May 23, 2022
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label May 23, 2022
@Naarcha-AWS Naarcha-AWS merged commit 18c6e9c into main May 23, 2022
@Naarcha-AWS Naarcha-AWS deleted the lukas-vlcek-improve_cluster_health branch September 14, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cluster health Reference REST API is missing wait_for_nodes param
6 participants