Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update connector documentation error #9122

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

b4sjoo
Copy link
Contributor

@b4sjoo b4sjoo commented Jan 28, 2025

Description

Previously we had an incomplete documentation on updating the connector, which misled our customer. Now we add documentation to show customer how to update internal connector and stand-alone connector.

Issues Resolved

Closes #9121

Version

2.13-now

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Signed-off-by: Fanit Kolchina <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws added backport 2.13 PR: Backport label for 2.13 backport 2.14 PR: Backport label for 2.14 backport 2.15 backport 2.16 backport 2.17 Backport for version 2.17 backport 2.18 PR: Backport label for 2.18 labels Jan 28, 2025
@kolchfa-aws kolchfa-aws merged commit 9e51185 into opensearch-project:main Jan 28, 2025
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 28, 2025
* Fix update connector documentation error

Signed-off-by: Sicheng Song <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 9e51185)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 28, 2025
* Fix update connector documentation error

Signed-off-by: Sicheng Song <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 9e51185)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 28, 2025
* Fix update connector documentation error

Signed-off-by: Sicheng Song <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 9e51185)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 28, 2025
* Fix update connector documentation error

Signed-off-by: Sicheng Song <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 9e51185)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 28, 2025
* Fix update connector documentation error

Signed-off-by: Sicheng Song <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 9e51185)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 28, 2025
* Fix update connector documentation error

Signed-off-by: Sicheng Song <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 9e51185)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.13 PR: Backport label for 2.13 backport 2.14 PR: Backport label for 2.14 backport 2.15 backport 2.16 backport 2.17 Backport for version 2.17 backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Change wrong description in update connector credential
3 participants