[Backport 2.x] Re-enabled multi-node integration tests and Fix integration test set up #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(opensearch-project#432) * Wiping system indices, moving ml config check to individual tests that create a connector Signed-off-by: Joshua Palis <[email protected]> * spotless Signed-off-by: Joshua Palis <[email protected]> * Increasing ML config index timeout for multi-node case Signed-off-by: Joshua Palis <[email protected]> * Including flow framework config in wipeAllODFEIndices method Signed-off-by: Joshua Palis <[email protected]> * exluding model group index from wipe Signed-off-by: Joshua Palis <[email protected]> * testing wipe all indices with client Signed-off-by: Joshua Palis <[email protected]> * Reverting wipe method back to adminClient Signed-off-by: Joshua Palis <[email protected]> * removing deprovision from model tests, not necessary since we're wiping indices after each test run Signed-off-by: Joshua Palis <[email protected]> * Wrapping testFailedUpdateWorkflow provision in ml config check Signed-off-by: Joshua Palis <[email protected]> * Fixing failing security tests Signed-off-by: Joshua Palis <[email protected]> * Testing model redeploy settings Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> Co-authored-by: Owais Kazi <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #434 +/- ##
============================================
+ Coverage 71.72% 71.88% +0.15%
- Complexity 619 620 +1
============================================
Files 78 78
Lines 3126 3126
Branches 236 236
============================================
+ Hits 2242 2247 +5
+ Misses 776 772 -4
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f039d7f from #432