Fix the bugs in visual UI for legacy notification #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 50.05% 50.04% -0.02%
==========================================
Files 154 154
Lines 4387 4388 +1
Branches 682 682
==========================================
Hits 2196 2196
- Misses 2035 2036 +1
Partials 156 156
Continue to review full report at Codecov.
|
annie3431
previously approved these changes
Oct 19, 2021
bowenlan-amzn
approved these changes
Oct 20, 2021
annie3431
approved these changes
Oct 20, 2021
lobdelle
added a commit
that referenced
this pull request
Nov 5, 2021
* Fixes editing rollup delay (#82) * Fixes editing the delay amount and displaying the schedule for rollups Signed-off-by: Clay Downs <[email protected]> * Bumps version to 1.2 (#103) * Bumps version to 1.2 * Changes test workflows to follow Dashboards 1.x Signed-off-by: Clay Downs <[email protected]> * Fixes flakey tests (#105) * Fixes flakey cypress test 'rollup enable and disable test' * Fixes flakey unit test 'can delete a rollup job' Signed-off-by: Robert Downs <[email protected]> * Fixed Transforms geo_point bug and boolean render (#93) * Fixed Transforms geo_point bug and boolean render * Set default DefineTransforms table render behavior to JSON.stringify * Updated DefineTransforms null cell value check Signed-off-by: Eric Lobdell <[email protected]> * Transform bug fixes (#109) * Rename plugin helper file * Update TransformIndices.tsx * Backport commits from main (#90) * Release 1.1.0.0 (#83) * Release 1.1.0.0 Signed-off-by: bowenlan-amzn <[email protected]> * Correct copyright notices * UI fixes for new ISM UI (#84) * Removes X icon from action/transition flyout footer next to cancel Signed-off-by: Drew Baugher <[email protected]> * Adds tooltips to edit/delete icon buttons on the draggable action/transition components Signed-off-by: Drew Baugher <[email protected]> * Removes overlay for flyout so clicking outside doesn't close flyout and removes X close button on top right Signed-off-by: Drew Baugher <[email protected]> * Adds edit/delete tooltips for state component and removes underline from hovering states Signed-off-by: Drew Baugher <[email protected]> * Changes state flyout from X Close to Cancel Signed-off-by: Drew Baugher <[email protected]> * Adds JSON editor for allocation action Signed-off-by: Drew Baugher <[email protected]> * Adds isValid to action interface and implements in actions Signed-off-by: Drew Baugher <[email protected]> * Correctly removes unused rollover keys from rollover object, handles uncontrolled inputs and NaN minDocs Signed-off-by: Drew Baugher <[email protected]> * Adds error for state name already existing in policy Signed-off-by: Drew Baugher <[email protected]> * Fixes duplicated actions when editing as previously we had a new ID and matching logic didn't find an action Signed-off-by: Drew Baugher <[email protected]> * Fixes other action inputs that can return NaN and creates a no conditions option that is the default Signed-off-by: Drew Baugher <[email protected]> * Updates snapshot Signed-off-by: Drew Baugher <[email protected]> * Correctly show danger toast on update/create failures Signed-off-by: Drew Baugher <[email protected]> * Fixes rollup action nesting multiple ism_template keys Signed-off-by: Drew Baugher <[email protected]> * Fixes timeout/retry settings turning into uncontrolled inputs and NaN value Signed-off-by: Drew Baugher <[email protected]> * Removes text transformation on inputs and updates isValid methods and passes to form labels Signed-off-by: Drew Baugher <[email protected]> * Fixes allocation and rollup adding UIAction properties to policy JSON on updates Signed-off-by: Drew Baugher <[email protected]> * Updates release notes w/ new PR changes Signed-off-by: Drew Baugher <[email protected]> * Wraps actions/transitions in states component and updates default rollup to include ism_rollup key Signed-off-by: Drew Baugher <[email protected]> * Fixes some small UI touchups/issues for new ISM UI (#85) * Moves cancel secondary button next to primary on action/transition flyout Signed-off-by: Drew Baugher <[email protected]> * Removes default ISM template and increases width of empty prompt Signed-off-by: Drew Baugher <[email protected]> * Adds punctuation Signed-off-by: Drew Baugher <[email protected]> * Adds back X icon next to cancel for state flyout Signed-off-by: Drew Baugher <[email protected]> * Makes inputs in flyout full width, updates help text, and adds some spacing Signed-off-by: Drew Baugher <[email protected]> * Updates transition default to not include conditions empty object, and on change transition to delete conditions when selecting none Signed-off-by: Drew Baugher <[email protected]> * Moves edit button out of policy settings content panel and on to global page for view policy Signed-off-by: Drew Baugher <[email protected]> * Updates release note Signed-off-by: Drew Baugher <[email protected]> * Fixes broken link Signed-off-by: Drew Baugher <[email protected]> * Fixes small issues on new ISM UI (#88) * Fixes small issues on new ISM UI Signed-off-by: Drew Baugher <[email protected]> * Updates snapshots Signed-off-by: Drew Baugher <[email protected]> * Updates release notes Signed-off-by: Drew Baugher <[email protected]> * Updates workflows to trigger on 1.* branches Signed-off-by: Drew Baugher <[email protected]> Co-authored-by: Bowen Lan <[email protected]> * Support data filter when viewing sample data * Update TransformOptions.tsx * Add TransformService.test.ts * Draft of date histogram panel * Add helper method and move import * Split calendar and fixed interval to 2 panels * Add rendering test * Add close popover test * Update cypress-workflow.yml * Update links.yml * Update unit-tests-workflow.yml * Update TransformOptions.tsx * Update tests * Update DateHistogramPanel.test.tsx * Make scripted metrics editor larger * Expand code editor related panels * Undo changes to workflow Signed-off-by: Annie Lee <[email protected]> * Update TimeAggregation.tsx * Update DefineTransforms.tsx undo changes to style * Clean up code * Update snapshot Signed-off-by: Annie Lee <[email protected]> * Refactor the order of checking if name is defined before checking for duplicate name * Update CreateTransformForm.tsx * Update DefineTransforms.tsx Signed-off-by: Annie Lee <[email protected]> * Update DefineTransforms.tsx Signed-off-by: Annie Lee <[email protected]> * Update DefineTransforms.tsx * Update DefineTransforms.tsx * Update DefineTransforms.tsx Co-authored-by: Drew Baugher <[email protected]> Co-authored-by: Bowen Lan <[email protected]> * Fix the bugs in visual UI for legacy notification (#111) * Transforms unit and cypress tests (#92) * Transform cypress tests (#21) * Added Cypress tests for Transforms UI * License update * Unit tests initial commit * Added jest tests for Transforms, details, edit and create * Sample transform fix * Fixed cypress test transform and sample data load order Signed-off-by: Eric Lobdell <[email protected]> * Test fix debug * Simplified unit test * Updated transforms cypress test comments and success criteria Signed-off-by: Eric Lobdell <[email protected]> * Fixed quotation mark issue in test Signed-off-by: Eric Lobdell <[email protected]> * Removed debug mapping and index objects from unit test Signed-off-by: Eric Lobdell <[email protected]> * Cypress test improvements and completed edit transform unit test Signed-off-by: Eric Lobdell <[email protected]> * Integ test delete fix and EditTransforms jest test fix Signed-off-by: Eric Lobdell <[email protected]> * Restoring enable disable page refresh delay to fix failing integ test Signed-off-by: Eric Lobdell <[email protected]> * Resolve test constants conflict Signed-off-by: Eric Lobdell <[email protected]> * Fix pagination of managed indices page (#113) * Disables jitter for managed_indices_spec Cypress tests (#122) Signed-off-by: Robert Downs <[email protected]> Co-authored-by: Clay Downs <[email protected]> Co-authored-by: Annie Lee <[email protected]> Co-authored-by: Drew Baugher <[email protected]> Co-authored-by: Bowen Lan <[email protected]> Co-authored-by: Ravi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable editing the legacy notification action in the visual editor
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.