Uses published daily snapshot dependencies #141
Conversation
|
That is interesting.... link checker fails because of link at bottom of rfc But why didn't it fail for previous PRs... |
Signed-off-by: Drew Baugher <[email protected]>
bowenlan-amzn
added
maintenance
| @@ -182,7 +182,7 @@ dependencies { | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
As part of the CI/CD we are trying to run integration/bwc tests which qualifies the bundle and allows the maven artifacts to be published.
It would rely on mavenlocal() to run these tests.
There was a problem hiding this comment.
Ah I see, I'll add it back w/ a comment explaining what it's for as it didn't seem needed in our repo.
There was a problem hiding this comment.
Did you need mavenLocal in the buildscript repositories too?
There was a problem hiding this comment.
Yeah still trying to figure out if there is any other way. But seems like mavenlocal() could be a simpler solution at this point.
The CI pipelines are in development we are learning through the process, so we didn't know either.
Could you point me to the buildscript ?
There was a problem hiding this comment.
https://github.com/opensearch-project/index-management/blob/main/build.gradle#L43-L47
I removed it from here too.
When you do your CI builds are you building release or snapshot? Because if you're also trying to build SNAPSHOT and I add this mavenLocal back.. then I have to add it to the top of the repositories so that it makes sure to check there first to find it (otherwise it'll find it first in our SNAPSHOT repository). But, if we do make mavenLocal first... now all devs/contributors need to make sure they clean out their local maven repositories of OpenSearch related artifacts if they want to make sure they are actually getting it from the SNAPSHOT repo which is a bit annoying.
There was a problem hiding this comment.
Yeah buildscript fetches the build-tools i.e opensearchplugin and it would depend on mavenlocal() too.
That is a great point. I think it would be SNAPSHOT repository but i'll get back on this.
There was a problem hiding this comment.
I really think you should back this out of 1.1 and make the change in 1.2. Branch for 1.1. We didn't give our maven publishing any bake time and the bundle build doesn't need more issues right now.
There was a problem hiding this comment.
@dblock This commit was not included in our 1.1 branch, and is not in our 1.x branch yet either. It's only in main.
| @@ -41,9 +41,9 @@ buildscript { | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
We need to preserve mavenLocal here for bundle build.
…pensearch-project#141) Combine API and other code fix
* Add integTest script to the repo (#94) Signed-off-by: Peter Zhu <[email protected]> * Removing Usages of Action Get Call and using listeners (#100) Signed-off-by: Aditya Jindal <[email protected]> * Enhance ISM template (#105) Signed-off-by: bowenlan-amzn <[email protected]> * Explain response still use old opendistro policy id (#109) * Explain response still use old opendistro policy id * Use hardcoded policyid setting in tests for explain response * Trying to fix flaky tests * Storing user information as part of the job when security plugin is installed (#113) Signed-off-by: Ravi Thaluru <[email protected]> * ISM/Notification channel support (#117) * Updates NAME of transport actions * Upgrades Kotlin version, updates dependencies on other OS plugins, adds notification plugin as a test resource and includes it in test clusters * Adds support for Channels in error notifications and notification actions * Adds support for sending notifications to channels * Adds support for publishing notifications to the legacy destinations through the Notification plugin and some cleanup * Removes notification alerting jar dependency * Adds compile only dep on commons codec for digest utils sha1 method in ism rollup * Updates Error Notification to make channel/destination nullable, and adds helper methods for publish calls * Constructs URL for legacy custom webhook Signed-off-by: Drew Baugher <[email protected]> * Fixes Feature enum and dep Signed-off-by: Drew Baugher <[email protected]> * Trying something else Signed-off-by: Drew Baugher <[email protected]> * Addresses comments Signed-off-by: Drew Baugher <[email protected]> * Storing user object in all APIs and enabling filter of response based on user (#115) Signed-off-by: Ravi Thaluru <[email protected]> * Upgrade dependencies to 1.1 and build snapshot by default. (#121) Signed-off-by: dblock <[email protected]> * Security improvements (#126) Signed-off-by: Ravi Thaluru <[email protected]> * Removes support for notification plugin (#136) Signed-off-by: Drew Baugher <[email protected]> * Updating security filtering logic (#137) Signed-off-by: Ravi Thaluru <[email protected]> * Release note for 1.1.0.0 release. (#139) * Release note for 1.1.0.0 release. Signed-off-by: bowenlan-amzn <[email protected]> * Correct copyright notices * Uses published daily snapshot dependencies (#141) Signed-off-by: Drew Baugher <[email protected]> * License header check (#142) * Provide default copyright header using IDE feature Signed-off-by: bowenlan-amzn <[email protected]> * Address #103 history write index is rolled over even if the history indices are disabled * Removed integtest.sh. (#148) Signed-off-by: dblock <[email protected]> * Adds mavenLocal back to repositories (#158) Signed-off-by: Drew Baugher <[email protected]> * Making snapshot name to scripted input in template (#77) Signed-off-by: Ravi Thaluru <[email protected]> * Fix issues with security changes in rollup runnner (#161) * Updates index management version to 1.2 (#157) * Updates index management version to 1.2 * Updates job scheduler snapshot to 1.2 in test resources Signed-off-by: Robert Downs <[email protected]> * Adds setting to search all rollup jobs on a target index (#165) * Adds cluster setting to search all rollup jobs Signed-off-by: Clay Downs <[email protected]> * Adds implementation for the delay feature in rollup jobs (#147) * Adds delay implementation for rollup jobs * Removes non-continuous delay implementation * Adds additional rollup delay tests Signed-off-by: Clay Downs <[email protected]> * Updates testCompile mockito version, adds AwaitsFix annotation to MetadataRegressionIT tests (#168) * Updates testCompile mockito version to match OpenSearch changes * AwaitsFix on the failing MetadataRegressionIT tests Signed-off-by: Robert Downs <[email protected]> * Adds cluster setting to configure index state management jitter (#153) * Adds jitter cluster setting, sets jitter to 0 for ISM tests Signed-off-by: Clay Downs <[email protected]> * Allows out of band rollovers on an index without causing ISM to fail (#180) * Allows out of band rollovers on an index without causing ISM to fail Signed-off-by: Drew Baugher <[email protected]> * Fixes detekt issue Signed-off-by: Drew Baugher <[email protected]> * Remove policy API on read only indices (#182) * In explain API not showing the total count to all users (#185) Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Aditya Jindal <[email protected]> Co-authored-by: Bowen Lan <[email protected]> Co-authored-by: Ravi <[email protected]> Co-authored-by: Drew Baugher <[email protected]> Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
Signed-off-by: Drew Baugher <[email protected]>
Signed-off-by: Drew Baugher [email protected]
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.