Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest APIs Backward Compatibility #15

Merged
merged 8 commits into from
May 21, 2021

Conversation

bowenlan-amzn
Copy link
Member

Issue #, if available:
#11

Description of changes:

CheckList:
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #15 (b620606) into main (d41f662) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #15      +/-   ##
============================================
- Coverage     76.87%   76.84%   -0.04%     
- Complexity     1544     1558      +14     
============================================
  Files           199      199              
  Lines          8325     8395      +70     
  Branches       1323     1323              
============================================
+ Hits           6400     6451      +51     
- Misses         1228     1246      +18     
- Partials        697      698       +1     
Impacted Files Coverage Δ Complexity Δ
...pensearch/indexmanagement/IndexManagementPlugin.kt 89.13% <ø> (ø) 12.00 <0.00> (ø)
...statemanagement/resthandler/RestAddPolicyAction.kt 80.00% <100.00%> (+6.66%) 8.00 <1.00> (+1.00)
...temanagement/resthandler/RestChangePolicyAction.kt 95.00% <100.00%> (+1.66%) 7.00 <1.00> (+1.00)
...temanagement/resthandler/RestDeletePolicyAction.kt 85.71% <100.00%> (+3.89%) 5.00 <1.00> (+1.00)
...exstatemanagement/resthandler/RestExplainAction.kt 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)
...statemanagement/resthandler/RestGetPolicyAction.kt 96.66% <100.00%> (+1.01%) 6.00 <1.00> (+1.00)
...atemanagement/resthandler/RestIndexPolicyAction.kt 95.12% <100.00%> (+0.67%) 9.00 <1.00> (+1.00)
...temanagement/resthandler/RestRemovePolicyAction.kt 93.75% <100.00%> (+2.84%) 8.00 <1.00> (+1.00)
...t/resthandler/RestRetryFailedManagedIndexAction.kt 85.71% <100.00%> (+4.46%) 7.00 <1.00> (+1.00)
...refreshanalyzer/RestRefreshSearchAnalyzerAction.kt 94.11% <100.00%> (+2.45%) 8.00 <1.00> (+1.00)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41f662...b620606. Read the comment docs.

const val OPEN_DISTRO_BASE_URI = "/_opendistro"
const val ISM_BASE_URI = "$OPEN_DISTRO_BASE_URI/_ism"
const val ROLLUP_BASE_URI = "$OPEN_DISTRO_BASE_URI/_rollup"
const val IM_BASE_URI = "/_plugins"
Copy link
Contributor

@thalurur thalurur May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: can you rename this to PLUGINS_BASE_URI?

@bowenlan-amzn bowenlan-amzn merged commit eee3191 into opensearch-project:main May 21, 2021
thalurur pushed a commit to thalurur/open-index-management that referenced this pull request Oct 22, 2021
@bowenlan-amzn bowenlan-amzn deleted the restapi branch November 16, 2022 07:54
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
* Rest APIs Backward Compatibility

Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants