Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.3.1 #314

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Bump version to 1.3.1 #314

merged 3 commits into from
Mar 28, 2022

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Mar 25, 2022

Signed-off-by: Sayali Gaikawad [email protected]

Issue #, if available:
Part of opensearch-project/opensearch-build#1805
Description of changes:
Bump version to 1.3.1
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya requested a review from a team March 25, 2022 23:46
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022

Codecov Report

Merging #314 (2444e34) into 1.3 (c5d4ffc) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #314      +/-   ##
============================================
+ Coverage     75.78%   75.86%   +0.08%     
- Complexity     2006     2007       +1     
============================================
  Files           253      253              
  Lines         11467    11467              
  Branches       1815     1815              
============================================
+ Hits           8690     8700      +10     
+ Misses         1747     1737      -10     
  Partials       1030     1030              
Impacted Files Coverage Δ
.../action/explain/TransportExplainTransformAction.kt 67.04% <0.00%> (-2.28%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 84.43% <0.00%> (+0.47%) ⬆️
...exmanagement/opensearchapi/OpenSearchExtensions.kt 87.65% <0.00%> (+1.23%) ⬆️
...ch/indexmanagement/rollup/RollupMetadataService.kt 76.92% <0.00%> (+2.40%) ⬆️
.../opensearch/indexmanagement/rollup/RollupRunner.kt 69.91% <0.00%> (+4.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d4ffc...2444e34. Read the comment docs.

@downsrob
Copy link
Contributor

Multi node tests are failing because the notification 1.3.1.0-SNAPSHOT is not yet published.

The test and build workflow should also be failing, but the version was not updated there. Could you update the version to 1.3.1 in the test and build workflow and multi node test workflow files?

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya
Copy link
Member Author

Multi node tests are failing because the notification 1.3.1.0-SNAPSHOT is not yet published.

The test and build workflow should also be failing, but the version was not updated there. Could you update the version to 1.3.1 in the test and build workflow and multi node test workflow files?

Hi @downsrob ,
I updated the versions and notification dependency is available too now. Still few tests are failing. Do I need to update the Job scheduler zips to 1.3.1.0 too?

@downsrob
Copy link
Contributor

@gaiksaya Yes, you need to update that zip as well. Sorry, we will remove that dependency by 2.0

Signed-off-by: Sayali Rohidas Gaikawad <[email protected]>
@bowenlan-amzn bowenlan-amzn merged commit 5f6cf7f into opensearch-project:1.3 Mar 28, 2022
@gaiksaya gaiksaya deleted the 1.3.1 branch March 28, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants