Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented assertion in transform runner test that fails once it's bee… #581

Conversation

stevanbz
Copy link
Contributor

…n executed on ubuntu instances

Issue #, if available:

Description of changes:
Commented assertion in the TransformRunnerIT.test transform with data filter test since it seems that the search is done in less than 1 ms
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@stevanbz stevanbz requested a review from a team October 28, 2022 20:56
khushbr
khushbr previously approved these changes Oct 28, 2022
Copy link
Contributor

@khushbr khushbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us add this commit and test failure info to #90

Angie-Zhang
Angie-Zhang previously approved these changes Oct 28, 2022
@stevanbz stevanbz mentioned this pull request Oct 28, 2022
…n executed on ubuntu instances

Signed-off-by: Stevan Buzejic <[email protected]>
@stevanbz stevanbz dismissed stale reviews from Angie-Zhang and khushbr via f2673b9 October 28, 2022 21:12
@stevanbz stevanbz force-pushed the commented-transform-with-data-filter-test branch from 71ea784 to f2673b9 Compare October 28, 2022 21:12
@khushbr khushbr merged commit 1856295 into opensearch-project:main Oct 28, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
 The transform runner test completes the search in sub-millisecond, thus failing. This is specific to Ubuntu 17 & 11 distribution.

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
(cherry picked from commit 1856295)
Angie-Zhang pushed a commit that referenced this pull request Oct 31, 2022
The transform runner test completes the search in sub-millisecond, thus failing. This is specific to Ubuntu 17 & 11 distribution.

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
(cherry picked from commit 1856295)

Co-authored-by: Stevan Buzejic <[email protected]>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
) (opensearch-project#582)

The transform runner test completes the search in sub-millisecond, thus failing. This is specific to Ubuntu 17 & 11 distribution.

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
(cherry picked from commit 1856295)

Co-authored-by: Stevan Buzejic <[email protected]>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
) (opensearch-project#582)

The transform runner test completes the search in sub-millisecond, thus failing. This is specific to Ubuntu 17 & 11 distribution.

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
(cherry picked from commit 1856295)

Co-authored-by: Stevan Buzejic <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants