Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set preference to _primary when searching control-center index #911

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Set preference to _primary when searching control-center index #911

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1560d15
Set preference to _primary when searching control-center index
gaobinlong Aug 30, 2023
767fd6e
Use _primary_first instead
gaobinlong Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...rch/indexmanagement/controlcenter/notification/action/get/TransportGetLRONConfigAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import org.opensearch.action.search.SearchResponse
import org.opensearch.action.support.ActionFilters
import org.opensearch.action.support.HandledTransportAction
import org.opensearch.client.node.NodeClient
import org.opensearch.cluster.routing.Preference
import org.opensearch.common.inject.Inject
import org.opensearch.common.xcontent.LoggingDeprecationHandler
import org.opensearch.common.xcontent.XContentHelper
Expand Down Expand Up @@ -93,6 +94,7 @@ class TransportGetLRONConfigAction @Inject constructor(
val searchRequest = SearchRequest()
.source(searchSourceBuilder)
.indices(IndexManagementPlugin.CONTROL_CENTER_INDEX)
.preference(Preference.PRIMARY.type())
Copy link
Member

@dreamer-89 dreamer-89 Aug 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaobinlong for this change.

Please note that using _primary preference may result in failure if primary shard is not avaialble thus there is availability hit. If availability is important than consistency, then you can use _primary_first parameter, which routes the request to primary first (as name suggest). If primary is unavailable the request is routed to replica shards, though data can be stale when served from replicas. The choice you have to make is b/w consistency (_primary) vs availablility (_primary_first). I will let you take this decision based on your use case.

CC @getsaurabh02 @bowenlan-amzn


client.search(
searchRequest,
Expand Down