Address PR Feedback

Signed-off-by: Ryan Bogan <[email protected]>
opensearch-project · Dec 7, 2023 · 586797f · 586797f
1 parent bf4407d
commit 586797f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java b/src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java
@@ -164,7 +164,7 @@ private void updateModelStateAsFailed(Model model, String msg) throws IOExceptio
         modelDao.update(model, new ActionListener<IndexResponse>() {
             @Override
             public void onResponse(IndexResponse indexResponse) {
-                log.info("Model " + model.getModelID() + " marked as " + model.getModelMetadata().getState());
+                log.info("Model {} marked as {}", model.getModelID(), model.getModelMetadata().getState());
             }
 
             @Override

diff --git a/src/main/java/org/opensearch/knn/training/TrainingJobRunner.java b/src/main/java/org/opensearch/knn/training/TrainingJobRunner.java
@@ -154,7 +154,7 @@ private void train(TrainingJob trainingJob) {
             try {
                 serializeModel(trainingJob, loggingListener, true);
             } catch (IOException | ExecutionException | InterruptedException e) {
-                logger.error("Unable to serialize the failure for model \"%\": ", trainingJob.getModelId(), e);
+                logger.error("Unable to serialize the failure for model \"{}\": ", trainingJob.getModelId(), e);
             } finally {
                 jobCount.decrementAndGet();
                 semaphore.release();
@@ -170,7 +170,7 @@ private void serializeModel(TrainingJob trainingJob, ActionListener<IndexRespons
             if (model.getModelMetadata().getState().equals(ModelState.TRAINING)) {
                 modelDao.update(trainingJob.getModel(), listener);
             } else {
-                logger.info("Model state is %. Skipping serialization of trained data", model.getModelMetadata().getState());
+                logger.info("Model state is {}. Skipping serialization of trained data", model.getModelMetadata().getState());
             }
         } else {
             modelDao.put(trainingJob.getModel(), listener);