Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [k-NN] Add Clear Cache API #1055

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 12f4a51 from #740

@naveentatikonda
Copy link
Member

Leaving this PR open until AppSec review and Pentest is done.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Attention: Patch coverage is 85.71429% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.07%. Comparing base (551068b) to head (70bca5f).
Report is 4 commits behind head on 2.x.

❗ Current head 70bca5f differs from pull request most recent head 2464811. Consider uploading reports for the commit 2464811 to get more accurate results

Files Patch % Lines
...n/java/org/opensearch/knn/index/KNNIndexShard.java 80.00% 3 Missing ⚠️
...search/knn/plugin/transport/ClearCacheRequest.java 50.00% 2 Missing ⚠️
...earch/knn/plugin/transport/ClearCacheResponse.java 50.00% 2 Missing ⚠️
...nn/plugin/transport/ClearCacheTransportAction.java 86.66% 2 Missing ⚠️
...nsearch/knn/plugin/transport/ClearCacheAction.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1055      +/-   ##
============================================
+ Coverage     84.86%   85.07%   +0.21%     
+ Complexity     1343     1174     -169     
============================================
  Files           167      159       -8     
  Lines          5516     4770     -746     
  Branches        548      430     -118     
============================================
- Hits           4681     4058     -623     
+ Misses          602      519      -83     
+ Partials        233      193      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jmazanec15
jmazanec15 previously approved these changes Nov 27, 2023
@naveentatikonda naveentatikonda dismissed stale reviews from jmazanec15 and themself via 5c59e26 April 12, 2024 21:39
@naveentatikonda naveentatikonda force-pushed the backport/backport-740-to-2.x branch from 70bca5f to 5c59e26 Compare April 12, 2024 21:39
* Add Clear Cache API

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add Unit and Integration tests

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add BWC Tests

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add CHANGELOG

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

---------

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit 12f4a51)
Signed-off-by: Naveen Tatikonda <[email protected]>
@naveentatikonda naveentatikonda force-pushed the backport/backport-740-to-2.x branch from 5c59e26 to b8abb56 Compare April 12, 2024 21:49
@navneet1v
Copy link
Collaborator

@naveentatikonda thanks for fixing the tests

@naveentatikonda naveentatikonda merged commit 78a489a into 2.x Apr 13, 2024
78 of 82 checks passed
@github-actions github-actions bot deleted the backport/backport-740-to-2.x branch April 13, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants