Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Bump lucene codec to 99 #1386

Merged

Conversation

naveentatikonda
Copy link
Member

Signed-off-by: Naveen Tatikonda [email protected]
(cherry picked from commit 45e9e54)

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Add Lucene Codec 9.9

Signed-off-by: Naveen Tatikonda <[email protected]>

* Fix import statements for Lucene95 Codec

Signed-off-by: Naveen Tatikonda <[email protected]>

* Fix SegmentInfo Constructor in Test

Signed-off-by: Naveen Tatikonda <[email protected]>

* Temporarily Ignore Old Codec Tests

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add CHANGELOG

Signed-off-by: Naveen Tatikonda <[email protected]>

* Delete Old Codec Tests

Signed-off-by: Naveen Tatikonda <[email protected]>

---------

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit 45e9e54)
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c65643) 85.21% compared to head (8a48f38) 84.93%.

Files Patch % Lines
...ec/KNN990Codec/KNN990PerFieldKnnVectorsFormat.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1386      +/-   ##
============================================
- Coverage     85.21%   84.93%   -0.29%     
+ Complexity     1239     1238       -1     
============================================
  Files           158      160       +2     
  Lines          5059     5083      +24     
  Branches        482      482              
============================================
+ Hits           4311     4317       +6     
- Misses          543      562      +19     
+ Partials        205      204       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naveentatikonda naveentatikonda merged commit 7900dbb into opensearch-project:2.x Jan 12, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants