Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add painless script support for hamming with binary vector data type #1839

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add painless script support for hamming with binary vector data type #1839

merged 1 commit into from
Jul 17, 2024

Conversation

heemin32
Copy link
Collaborator

@heemin32 heemin32 commented Jul 16, 2024 •
edited
Loading

Description

Add painless script support for hamming with binary vector data type

Changes are

  1. Moved all painless script method to the bottom of the class for better readability.
  2. Added a validation on all existing painless method to block binary vector
  3. Added a painless method for hamming with binary vector

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heemin32 heemin32 force-pushed the painless branch 2 times, most recently from 2491eda to 41668ba Compare July 17, 2024 01:47
@heemin32
Copy link
Collaborator Author

BWS is failing with Exception in thread "main" java.io.FileNotFoundException: /home/runner/work/k-NN/k-NN/qa/rolling-upgrade/build/private/artifact_tmp/opensearch-knn-2.16.0.zip (No such file or directory)
Seems like something fundamental is broken for knn repo

@navneet1v
Copy link
Collaborator

BWS is failing with Exception in thread "main" java.io.FileNotFoundException: /home/runner/work/k-NN/k-NN/qa/rolling-upgrade/build/private/artifact_tmp/opensearch-knn-2.16.0.zip (No such file or directory) Seems like something fundamental is broken for knn repo

and who is looking into this?

@navneet1v
Copy link
Collaborator

@heemin32 I can see this failing: https://github.com/opensearch-project/k-NN/actions/runs/9968357746/job/27544581924 do you know why?

@heemin32
Copy link
Collaborator Author

heemin32 commented Jul 17, 2024 •
edited
Loading

@heemin32 I can see this failing: https://github.com/opensearch-project/k-NN/actions/runs/9968357746/job/27544581924 do you know why?

I don't. Seems like authentication issue with the maven server? I see it started to failing since 19 hours ago. https://github.com/opensearch-project/k-NN/actions/runs/9963749910/job/27530469696

@heemin32
Copy link
Collaborator Author

sonatype did some migration and they reset our token. @peteralfonsi fixed the issue by generating a new token.

@heemin32
Copy link
Collaborator Author

For bwc test issue, the knn plugin is not available in 2.16-snapshot distribution due to build failure. @prudhvigodithi is working on it.

@prudhvigodithi prudhvigodithi mentioned this pull request Jul 17, 2024
Merged
jmazanec15
jmazanec15 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

junqiu-lei
junqiu-lei approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@junqiu-lei junqiu-lei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heemin32 heemin32 merged commit de6084f into opensearch-project:main Jul 17, 2024
18 of 52 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2024
@heemin32 @github-actions
Add painless script support for hamming with binary vector data type (#…
3c75a49 
…1839)

Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit de6084f)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 17, 2024
Merged
@heemin32 heemin32 deleted the painless branch July 17, 2024 23:55
heemin32 added a commit that referenced this pull request Jul 18, 2024
@opensearch-trigger-bot @heemin32
Add painless script support for hamming with binary vector data type (#…
5c4fad3 
…1839) (#1847)

Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit de6084f)

Co-authored-by: Heemin Kim <[email protected]>
naveentatikonda pushed a commit to naveentatikonda/k-NN that referenced this pull request Jul 20, 2024
@opensearch-trigger-bot @heemin32 @naveentatikonda
Add painless script support for hamming with binary vector data type (o…
e9e42eb 
…pensearch-project#1839) (opensearch-project#1847)

Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit de6084f)

Co-authored-by: Heemin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junqiu-lei junqiu-lei junqiu-lei approved these changes

@jmazanec15 jmazanec15 jmazanec15 approved these changes

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heemin32 @navneet1v @jmazanec15 @junqiu-lei