Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x] Backport cache maintenance PR and its recent fix #2390

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

owenhalpert
Copy link
Contributor

@owenhalpert owenhalpert commented Jan 14, 2025

Description

The auto-created backport PR #2383 failed and revealed an issue that needs to make it into mainline as well. Because only the backport PR failed, the original commit was not merged into the backport branch, so this PR manually backports the commits of both PRs by cherry-picking both onto the checked out 2.x branch. (#2387 and #2308).

Related Issues

#2308 (original cache maintenance PR)
#2387 (new fix to the above)

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owenhalpert owenhalpert changed the title [Manual backport] Backport cache maintenance PR and its recent fix [Manual backport 2.x] Backport cache maintenance PR and its recent fix Jan 14, 2025
@owenhalpert owenhalpert marked this pull request as ready for review January 14, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants