Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for knn to have qualifiers #329

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Mar 22, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Add support for knn to have qualifiers

Issues Resolved

Part of opensearch-project/opensearch-build#1624, opensearch-project/opensearch-build#1632
#315

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from jmazanec15 March 22, 2022 17:49
@peterzhuamazon peterzhuamazon merged commit 9b8895b into opensearch-project:main Mar 22, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-knn-qualifier-fix branch March 22, 2022 17:53
@martin-gaievski
Copy link
Member

@dblock @peterzhuamazon We have done another part of this change in a different PR - #324 assuming following - qualifier for plugin applies to both plugin and the base open-search versions as the same time (if I set qualifier to "alpha1" it will pull opensearch of version "alpha1" and build the plugin artifacts of "alpha1"). Is this correct understanding?

@peterzhuamazon
Copy link
Member Author

@dblock @peterzhuamazon We have done another part of this change in a different PR - #324 assuming following - qualifier for plugin applies to both plugin and the base open-search versions as the same time (if I set qualifier to "alpha1" it will pull opensearch of version "alpha1" and build the plugin artifacts of "alpha1"). Is this correct understanding?

Set opensearch.version to 2.0.0-alpha1 will pull 2.0.0-alpha1 opensearch.
build qualifier is to set your plugin to have alpha1 in knn build.

martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for build version qualifiers.
4 participants