-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]Improve test coverage for HttpJsonConnectorExecutor.java #1565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
============================================
+ Coverage 79.67% 80.74% +1.06%
- Complexity 4020 4182 +162
============================================
Files 394 399 +5
Lines 16385 16881 +496
Branches 1754 1817 +63
============================================
+ Hits 13055 13630 +575
+ Misses 2654 2537 -117
- Partials 676 714 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for raising the PR. DCO is missing (signoff). You can just do : |
Can we try to cover this code section too:
|
try { | ||
ConnectorAction predictAction = ConnectorAction.builder() | ||
.actionType(ConnectorAction.ActionType.PREDICT) | ||
.method("get") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like difference between invokeRemoteModel_GetMethodSuccessPath
& invokeRemoteModel_POSTMethodSuccessPath
is only here. May be we can use a function which could be reused to save lines?
Signed-off-by: TrungBui59 <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
@dhrubo-os I just reopen the PR |
@TrungBui59 no file is changed in this PR. Please reopen if needed. |
Description
[Describe what this change achieves]
Issues Resolved
#1381
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.