Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add checkstyle support in repo #1676

Closed
wants to merge 2 commits into from

Conversation

TrungBui59
Copy link
Contributor

Description

Adding spotless support for the repo

Issues Resolved

#1591

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: Patch coverage is 61.16751% with 153 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (5759bf2) to head (8dbd68e).
Report is 431 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/opensearch/ml/common/input/InputHelper.java 0.00% 33 Missing ⚠️
...src/main/java/org/opensearch/ml/common/MLTask.java 0.00% 17 Missing ⚠️
...opensearch/ml/common/conversation/Interaction.java 0.00% 15 Missing ⚠️
...earch/ml/common/conversation/ConversationMeta.java 0.00% 10 Missing ⚠️
...ensearch/ml/common/exception/ExecuteException.java 0.00% 6 Missing ⚠️
...n/java/org/opensearch/ml/common/dataframe/Row.java 61.53% 2 Missing and 3 partials ⚠️
...execute/metrics_correlation/MCorrModelTensors.java 16.66% 5 Missing ⚠️
...org/opensearch/ml/common/MLCommonsClassLoader.java 57.14% 3 Missing ⚠️
...g/opensearch/ml/common/connector/AwsConnector.java 40.00% 0 Missing and 3 partials ⚠️
...org/opensearch/ml/common/dataframe/ColumnType.java 57.14% 0 Missing and 3 partials ⚠️
... and 41 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1676      +/-   ##
============================================
+ Coverage     79.67%   80.75%   +1.08%     
- Complexity     4020     4187     +167     
============================================
  Files           394      399       +5     
  Lines         16385    16879     +494     
  Branches       1754     1819      +65     
============================================
+ Hits          13055    13631     +576     
+ Misses         2654     2534     -120     
- Partials        676      714      +38     
Flag Coverage Δ
ml-commons 80.75% <61.16%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -40,10 +40,12 @@ buildscript {
}

plugins {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add this in the whole repo. Let's add in the sub modules where it's missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is the same for every submodules, so is it make more sense to at it to the whole repo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylwu-amzn do you have any suggestion here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok for this as this will be applied to all modules. But feel free to comment if you have concerns

@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 16:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 16:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 16:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 16:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 16:51 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:32 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:32 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:33 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:33 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:33 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:46 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:46 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:46 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:46 — with GitHub Actions Inactive
@TrungBui59 TrungBui59 temporarily deployed to ml-commons-cicd-env November 24, 2023 17:46 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator

@TrungBui59 Could you please resolve the merge conflicts?

@mingshl
Copy link
Collaborator

mingshl commented Jan 10, 2025

spotless is added, closing PR

@mingshl mingshl closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants