-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add checkstyle support in repo #1676
Conversation
Signed-off-by: TrungBui59 <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
============================================
+ Coverage 79.67% 80.75% +1.08%
- Complexity 4020 4187 +167
============================================
Files 394 399 +5
Lines 16385 16879 +494
Branches 1754 1819 +65
============================================
+ Hits 13055 13631 +576
+ Misses 2654 2534 -120
- Partials 676 714 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -40,10 +40,12 @@ buildscript { | |||
} | |||
|
|||
plugins { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add this in the whole repo. Let's add in the sub modules where it's missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is the same for every submodules, so is it make more sense to at it to the whole repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ylwu-amzn do you have any suggestion here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok for this as this will be applied to all modules. But feel free to comment if you have concerns
@TrungBui59 Could you please resolve the merge conflicts? |
spotless is added, closing PR |
Description
Adding spotless support for the repo
Issues Resolved
#1591
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.