Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Issue 1787 fixing connector endpoint returns index not found #1885

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[Backport 2.x] Issue 1787 fixing connector endpoint returns index not found #1885

merged 1 commit into from
Jan 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 38b51f2 from #1870

@sam-herman @github-actions
Issue 1787 fixing connector endpoint returns index not found (#1870)
83c3346 
* fix connector endpoint message, fix cluster debug mode for integ tests, add log output for integ tests

Signed-off-by: Samuel Herman <[email protected]>

* javaSpotCheckApply

Signed-off-by: Samuel Herman <[email protected]>

* PR feedback - unwrap exception

Signed-off-by: Samuel Herman <[email protected]>

* add more tests to get jacoco approve the test coverage

Signed-off-by: Samuel Herman <[email protected]>

---------

Signed-off-by: Samuel Herman <[email protected]>
(cherry picked from commit 38b51f2)
@ylwu-amzn
Copy link
Collaborator

@samuel-oci DCO check failed https://github.com/opensearch-project/ml-commons/pull/1885/checks?check_run_id=20590041163

@sam-herman
Copy link
Collaborator

@samuel-oci DCO check failed https://github.com/opensearch-project/ml-commons/pull/1885/checks?check_run_id=20590041163

Hi @ylwu-amzn , I see that the DCO check was fine on the PR: https://github.com/opensearch-project/ml-commons/pull/1870/checks

Is it possible that this was introduced as a result of the squash commit when merged?

@ylwu-amzn
Copy link
Collaborator

@samuel-oci DCO check failed https://github.com/opensearch-project/ml-commons/pull/1885/checks?check_run_id=20590041163

Hi @ylwu-amzn , I see that the DCO check was fine on the PR: https://github.com/opensearch-project/ml-commons/pull/1870/checks

Is it possible that this was introduced as a result of the squash commit when merged?

From the doc https://github.com/opensearch-project/ml-commons/pull/1885/checks?check_run_id=20590041163

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

@ylwu-amzn
Copy link
Collaborator

I set DCO as passed manually

@ylwu-amzn ylwu-amzn merged commit 222e994 into 2.x Jan 18, 2024
10 of 12 checks passed
@github-actions github-actions bot deleted the backport/backport-1870-to-2.x branch January 18, 2024 01:00
@dhrubo-os
Copy link
Collaborator

Is it possible that this was introduced as a result of the squash commit when merged?

@samuel-oci can you please make sure your email address in github is public? This error happens during backport when backport workflow can't retrieve your email from your profile in my understanding. Thanks.

@sam-herman
Copy link
Collaborator

Is it possible that this was introduced as a result of the squash commit when merged?

@samuel-oci can you please make sure your email address in github is public? This error happens during backport when backport workflow can't retrieve your email from your profile in my understanding. Thanks.

Sure @dhrubo-os , that makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ylwu-amzn @sam-herman @dhrubo-os @Zhangxunmt