Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated Cohere Embedding blueprint #1950

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

tianjing-li
Copy link
Contributor

@tianjing-li tianjing-li commented Jan 29, 2024

Description

[Describe what this change achieves]

Updates Cohere blueprint documentation, merging the two existing blueprints into one, as both were made to integrate the same /embed API call but with different model params. Clarifies some of the steps, and adds steps to optionally add ingestion pipeline.

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tianjing-li
Copy link
Contributor Author

There is also some documentation here: https://opensearch.org/docs/latest/ml-commons-plugin/remote-models/connectors/, I'd like to update it because some of the info is out of date - can someone point me to where that lives?

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd8b6ab) 82.82% compared to head (a9c500a) 82.85%.
Report is 23 commits behind head on main.

❗ Current head a9c500a differs from pull request most recent head 23e7804. Consider uploading reports for the commit 23e7804 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1950      +/-   ##
============================================
+ Coverage     82.82%   82.85%   +0.02%     
- Complexity     5446     5450       +4     
============================================
  Files           522      522              
  Lines         21903    21903              
  Branches       2227     2227              
============================================
+ Hits          18142    18147       +5     
+ Misses         2852     2846       -6     
- Partials        909      910       +1     
Flag Coverage Δ
ml-commons 82.85% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianjing-li tianjing-li temporarily deployed to ml-commons-cicd-env January 29, 2024 22:14 — with GitHub Actions Inactive
}
```

You can then check whether the registration task has completed with a GET request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 108 to 127 is not needed, as user can see the model id directly from line 104

@tianjing-li
Copy link
Contributor Author

@ylwu-amzn done

@ylwu-amzn ylwu-amzn merged commit 6def544 into opensearch-project:main Feb 7, 2024
6 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2024
* Add updated Cohere embedding blueprint

* Add updated Cohere embedding blueprint

* Update Cohere docs

* PR comments

* add missing period

* Remove committed doc

* Embedding updates

(cherry picked from commit 6def544)
ylwu-amzn pushed a commit that referenced this pull request Feb 7, 2024
* Add updated Cohere embedding blueprint

* Add updated Cohere embedding blueprint

* Update Cohere docs

* PR comments

* add missing period

* Remove committed doc

* Embedding updates

(cherry picked from commit 6def544)

Co-authored-by: Tianjing Li <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2024
* Add updated Cohere embedding blueprint

* Add updated Cohere embedding blueprint

* Update Cohere docs

* PR comments

* add missing period

* Remove committed doc

* Embedding updates

(cherry picked from commit 6def544)
dhrubo-os pushed a commit that referenced this pull request Feb 9, 2024
* Add updated Cohere embedding blueprint

* Add updated Cohere embedding blueprint

* Update Cohere docs

* PR comments

* add missing period

* Remove committed doc

* Embedding updates

(cherry picked from commit 6def544)

Co-authored-by: Tianjing Li <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
* Add updated Cohere embedding blueprint

* Add updated Cohere embedding blueprint

* Update Cohere docs

* PR comments

* add missing period

* Remove committed doc

* Embedding updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants