-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updated Cohere Embedding blueprint #1950
Conversation
There is also some documentation here: https://opensearch.org/docs/latest/ml-commons-plugin/remote-models/connectors/, I'd like to update it because some of the info is out of date - can someone point me to where that lives? |
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
============================================
+ Coverage 82.82% 82.85% +0.02%
- Complexity 5446 5450 +4
============================================
Files 522 522
Lines 21903 21903
Branches 2227 2227
============================================
+ Hits 18142 18147 +5
+ Misses 2852 2846 -6
- Partials 909 910 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
} | ||
``` | ||
|
||
You can then check whether the registration task has completed with a GET request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 108 to 127 is not needed, as user can see the model id directly from line 104
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
Outdated
Show resolved
Hide resolved
@ylwu-amzn done |
* Add updated Cohere embedding blueprint * Add updated Cohere embedding blueprint * Update Cohere docs * PR comments * add missing period * Remove committed doc * Embedding updates (cherry picked from commit 6def544)
* Add updated Cohere embedding blueprint * Add updated Cohere embedding blueprint * Update Cohere docs * PR comments * add missing period * Remove committed doc * Embedding updates (cherry picked from commit 6def544) Co-authored-by: Tianjing Li <[email protected]>
* Add updated Cohere embedding blueprint * Add updated Cohere embedding blueprint * Update Cohere docs * PR comments * add missing period * Remove committed doc * Embedding updates (cherry picked from commit 6def544)
* Add updated Cohere embedding blueprint * Add updated Cohere embedding blueprint * Update Cohere docs * PR comments * add missing period * Remove committed doc * Embedding updates (cherry picked from commit 6def544) Co-authored-by: Tianjing Li <[email protected]>
* Add updated Cohere embedding blueprint * Add updated Cohere embedding blueprint * Update Cohere docs * PR comments * add missing period * Remove committed doc * Embedding updates
Description
[Describe what this change achieves]
Updates Cohere blueprint documentation, merging the two existing blueprints into one, as both were made to integrate the same /embed API call but with different
model
params. Clarifies some of the steps, and adds steps to optionally add ingestion pipeline.Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.