Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the mlModel info in the deploy stage #2389

Merged
merged 1 commit into from
May 1, 2024
Merged

set the mlModel info in the deploy stage #2389

merged 1 commit into from
May 1, 2024

Conversation

Zhangxunmt
Copy link
Collaborator

Description

Set the mlModel info in the deployment. Also use the cached value outside of mlModel to obtain the ModelStatus.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:10 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:10 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:10 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:10 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:10 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:10 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:15 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:15 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:15 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:15 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:15 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:15 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt mentioned this pull request May 1, 2024
Closed
@zane-neo
Copy link
Collaborator

zane-neo commented May 1, 2024

Is this a critical issue that we need to release in 2.14?

zane-neo
zane-neo previously approved these changes May 1, 2024
View reviewed changes
@zane-neo
Copy link
Collaborator

zane-neo commented May 1, 2024

format code

@dhrubo-os
Copy link
Collaborator

apply spotless

@zane-neo zane-neo self-requested a review May 1, 2024 02:25
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 02:40 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:40 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:40 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 02:40 — with GitHub Actions Failure
@dhrubo-os
Copy link
Collaborator

let's push commit rather than amending the commit.

@Zhangxunmt
Copy link
Collaborator Author

let's push commit rather than amending the commit.

No for spotless. Check the commit history. How many meaningless commits we have for a single PR?

@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 03:40 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 03:40 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 03:40 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 03:40 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 03:40 — with GitHub Actions Error
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 03:40 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 04:37 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 04:37 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 04:37 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 04:37 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 1, 2024 04:37 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 1, 2024 04:37 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt merged commit ff6048f into opensearch-project:main May 1, 2024
10 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
@Zhangxunmt @github-actions
set the mlModel info in the deploy stage (#2389)
225882d 
Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit ff6048f)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 1, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
@Zhangxunmt @github-actions
set the mlModel info in the deploy stage (#2389)
d99d1c8 
Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit ff6048f)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 1, 2024
Merged
Zhangxunmt added a commit that referenced this pull request May 1, 2024
@opensearch-trigger-bot @Zhangxunmt
set the mlModel info in the deploy stage (#2389) (#2391)
c873f22 
Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit ff6048f)

Co-authored-by: Xun Zhang <[email protected]>
Zhangxunmt added a commit that referenced this pull request May 1, 2024
@opensearch-trigger-bot @Zhangxunmt
set the mlModel info in the deploy stage (#2389) (#2390)
d0695a0 
Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit ff6048f)

Co-authored-by: Xun Zhang <[email protected]>
dhrubo-os pushed a commit to dhrubo-os/ml-commons that referenced this pull request May 17, 2024
@opensearch-trigger-bot @Zhangxunmt @dhrubo-os
set the mlModel info in the deploy stage (opensearch-project#2389) (o…
591c4b9 
…pensearch-project#2390)

Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit ff6048f)

Co-authored-by: Xun Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zhangxunmt @zane-neo @dhrubo-os @ylwu-amzn