-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct NeuralQueryBuilder doEquals() and doHashCode(). #1045
Conversation
src/test/java/org/opensearch/neuralsearch/query/HybridQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
Please check the failed CIs and update the changelog file. |
src/main/java/org/opensearch/neuralsearch/query/NeuralQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralQueryBuilder.java
Outdated
Show resolved
Hide resolved
Blocking issue is fixed, you can use CI after rebasing on main branch |
CI actions are failing for the changes in this PR, please check:
|
Signed-off-by: Bo Zhang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
============================================
+ Coverage 80.14% 80.21% +0.07%
- Complexity 1136 1141 +5
============================================
Files 87 87
Lines 3934 3953 +19
Branches 662 666 +4
============================================
+ Hits 3153 3171 +18
Misses 532 532
- Partials 249 250 +1 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1045-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ec6b30d1bbea94e7d96d2f2232f510f775047293
# Push it to GitHub
git push --set-upstream origin backport/backport-1045-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Bo Zhang <[email protected]>
Description
NeuralQueryBuilder doEquals() and doHashCode() don't consider all the parameters so correct them to ensure those functions can work correctly if they are used for cache function.
Also fix the issue that we don't handle the queryImage properly. We should handle it similar to the queryText.
Related Issues
Resolves #1010
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.