[Backport 2.x] add hybrid search with rescore IT (#1066) #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-hwang
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
will-hwang
force-pushed
the
backport/backport-1066-to-2.x
branch
from
1c98376 to
b3b1eb6
Compare
will-hwang
changed the title
qa/rolling-upgrade/build.gradle
Outdated
| @@ -65,58 +65,6 @@ task testAgainstOldCluster(type: StandaloneRestIntegTestTask) { | |||
| systemProperty 'tests.plugin_bwc_version', ext.neural_search_bwc_version | |||
| systemProperty 'tests.skip_delete_model_index', 'true' | |||
|
|
|||
| //Excluding MultiModalSearchIT, HybridSearchIT, NeuralSparseSearchIT, NeuralQueryEnricherProcessorIT tests from neural search version 2.9 and 2.10 | |||
There was a problem hiding this comment.
we need all those checks in 2.x branch, don't remove them. 2.x rolling upgrade is running against all previous 2.x and latest 1.x
There was a problem hiding this comment.
addressed in the newest commit
* add hybrid search with rescore IT Signed-off-by: will-hwang <[email protected]> * remove rescore in hybrid search IT Signed-off-by: will-hwang <[email protected]> * remove previous version checks in build file Signed-off-by: will-hwang <[email protected]> * removing version checks only in rolling upgrade tests Signed-off-by: will-hwang <[email protected]> * remove newly added tests in restart test Signed-off-by: will-hwang <[email protected]> * Revert "remove newly added tests in restart test" This reverts commit 0987831. Signed-off-by: will-hwang <[email protected]> --------- Signed-off-by: will-hwang <[email protected]> (cherry picked from commit 97cf25c) Signed-off-by: will-hwang <[email protected]>
Signed-off-by: will-hwang <[email protected]>
Signed-off-by: will-hwang <[email protected]>
Signed-off-by: will-hwang <[email protected]>
will-hwang
force-pushed
the
backport/backport-1066-to-2.x
branch
from
8359a1b to
94e1120
Compare
|
Please update the PR description similar to other backport PRs. |
heemin32
approved these changes
Jan 9, 2025
martin-gaievski
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
97cf25cfrom #1066