Handle pagination_depth when from =0 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
zhichao-aws,
yuye-aws and
minalsha
as code owners
Signed-off-by: Varun Jain <[email protected]>
ryanbogan
approved these changes
Jan 22, 2025
owaiskazi19
reviewed
Jan 22, 2025
src/test/java/org/opensearch/neuralsearch/search/query/HybridCollectorManagerTests.java
Show resolved
Hide resolved
owaiskazi19
approved these changes
Jan 22, 2025
src/main/java/org/opensearch/neuralsearch/search/query/HybridCollectorManager.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/search/query/HybridCollectorManagerTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <[email protected]>
martin-gaievski
approved these changes
Jan 22, 2025
heemin32
approved these changes
Jan 22, 2025
vibrantvarun
added
the
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Handle pagination_depth when from =0 Signed-off-by: Varun Jain <[email protected]> * Add changelog Signed-off-by: Varun Jain <[email protected]> * Remove unecessary logs Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit 3dbdcba)
vibrantvarun
added a commit
that referenced
this pull request
Jan 22, 2025
* Handle pagination_depth when from =0 Signed-off-by: Varun Jain <[email protected]> * Add changelog Signed-off-by: Varun Jain <[email protected]> * Remove unecessary logs Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit 3dbdcba) Co-authored-by: Varun Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains following changes
Related Issues
1131
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.