[Backport 2.x] Validate Disjuction query in HybridQueryPhaseSearcher #1144
+124
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Validate Disjuction query in HybridQueryPhaseSearcher Signed-off-by: Owais <[email protected]> (cherry picked from commit 9799c6c)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1144 +/- ##
============================================
- Coverage 81.78% 81.55% -0.23%
Complexity 1244 1244
============================================
Files 93 93
Lines 4205 4219 +14
Branches 710 715 +5
============================================
+ Hits 3439 3441 +2
- Misses 498 507 +9
- Partials 268 271 +3 ☔ View full report in Codecov by Sentry. |
ryanbogan
approved these changes
Jan 24, 2025
vibrantvarun
approved these changes
Jan 24, 2025
junqiu-lei
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9799c6c from #1127