Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime exceptions in hybrid query for case when sub-query scorer return TwoPhase iterator that is incompatible with DISI iterator #624

Merged
merged 6 commits into from
Mar 11, 2024

Refactor non-concurrent collector manager

65553e7
Select commit
Loading
Failed to load commit list.
Merged

Fix runtime exceptions in hybrid query for case when sub-query scorer return TwoPhase iterator that is incompatible with DISI iterator #624

Refactor non-concurrent collector manager
65553e7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 11, 2024 in 1s

70.19% of diff hit (target 84.44%)

View this Pull Request on Codecov

70.19% of diff hit (target 84.44%)

Annotations

Check warning on line 67 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L67 

Added line #L67 was not covered by tests

Check warning on line 94 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L94 

Added line #L94 was not covered by tests

Check warning on line 96 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L96 

Added line #L96 was not covered by tests

Check warning on line 167 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L167 

Added line #L167 was not covered by tests

Check warning on line 172 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L172 

Added line #L172 was not covered by tests

Check warning on line 175 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L174-L175 

Added lines #L174 - L175 were not covered by tests

Check warning on line 184 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L184 

Added line #L184 was not covered by tests

Check warning on line 259 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L259 

Added line #L259 was not covered by tests

Check warning on line 261 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L261 

Added line #L261 was not covered by tests

Check warning on line 263 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L263 

Added line #L263 was not covered by tests

Check warning on line 317 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L316-L317 

Added lines #L316 - L317 were not covered by tests

Check warning on line 321 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L321 

Added line #L321 was not covered by tests

Check warning on line 330 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L330 

Added line #L330 was not covered by tests

Check warning on line 348 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L348 

Added line #L348 was not covered by tests

Check warning on line 367 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L367 

Added line #L367 was not covered by tests

Check warning on line 381 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L381 

Added line #L381 was not covered by tests

Check warning on line 389 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L389 

Added line #L389 was not covered by tests

Check warning on line 391 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L391 

Added line #L391 was not covered by tests

Check warning on line 80 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java#L80 

Added line #L80 was not covered by tests

Check warning on line 113 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java#L113 

Added line #L113 was not covered by tests

Check warning on line 154 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java#L154 

Added line #L154 was not covered by tests

Check warning on line 157 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java#L157 

Added line #L157 was not covered by tests

Check warning on line 160 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java#L159-L160 

Added lines #L159 - L160 were not covered by tests

Check warning on line 162 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java#L162 

Added line #L162 was not covered by tests

Check warning on line 31 in src/main/java/org/opensearch/neuralsearch/query/HybridScoreBlockBoundaryPropagator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridScoreBlockBoundaryPropagator.java#L30-L31 

Added lines #L30 - L31 were not covered by tests
View more details on Codecov