Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate Minal Shah (minalsha) as maintainer #971

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Oct 31, 2024

Nominating minalsha as maintainer of neural-search.
We have followed the OpenSearch process of becoming a maintainer and got an approval for minalsha from other maintainers.

Signed-off-by: Varun Jain <[email protected]>
@navneet1v
Copy link
Collaborator

You might want to update codeowners file too

Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun vibrantvarun added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Oct 31, 2024
@martin-gaievski martin-gaievski merged commit 180a5a6 into opensearch-project:main Oct 31, 2024
37 of 39 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-971-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 180a5a69034aa2043b7f6e98cf26d4f9c71db44d
# Push it to GitHub
git push --set-upstream origin backport/backport-971-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-971-to-2.x.

@vibrantvarun
Copy link
Member Author

@opensearch-project/admin Can you update the permissions for @minalsha and give her maintainer permissions?

@gaiksaya
Copy link
Member

@opensearch-project/admin Can you update the permissions for @minalsha and give her maintainer permissions?

Done!

martin-gaievski pushed a commit that referenced this pull request Nov 18, 2024
* update maintainers.md

Signed-off-by: Varun Jain <[email protected]>

* update codeowners file

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
zhichao-aws pushed a commit to zhichao-aws/neural-search that referenced this pull request Jan 6, 2025
* update maintainers.md

Signed-off-by: Varun Jain <[email protected]>

* update codeowners file

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants