Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test-mode flag from opensearch-benchmark command #3488

Merged
merged 1 commit into from
May 8, 2023
Merged

Remove test-mode flag from opensearch-benchmark command #3488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test_workflow/benchmark_test/benchmark_test_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(
if args.benchmark_config:
self.command += f" -v {args.benchmark_config}:/opensearch-benchmark/.benchmark/benchmark.ini"
self.command += f" opensearchproject/opensearch-benchmark:latest execute_test --workload={self.args.workload} " \
f"--test-mode --pipeline=benchmark-only --target-hosts={endpoint}"
f"--pipeline=benchmark-only --target-hosts={endpoint}"

if args.workload_params:
logging.info(f"Workload Params are {args.workload_params}")
Expand Down
6 changes: 3 additions & 3 deletions ...s/tests_test_workflow/test_benchmark_workflow/benchmark_test/test_benchmark_test_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def test_execute_default(self) -> None:
self.benchmark_test_suite.execute()
self.assertEqual(mock_check_call.call_count, 1)
self.assertEqual(self.benchmark_test_suite.command,
'docker run opensearchproject/opensearch-benchmark:latest execute_test --workload=nyc_taxis --test-mode '
'docker run opensearchproject/opensearch-benchmark:latest execute_test --workload=nyc_taxis '
'--pipeline=benchmark-only --target-hosts=abc.com')

def test_execute_security_enabled(self) -> None:
Expand All @@ -38,7 +38,7 @@ def test_execute_security_enabled(self) -> None:
self.assertEqual(mock_check_call.call_count, 1)
self.assertEqual(benchmark_test_suite.command,
'docker run opensearchproject/opensearch-benchmark:latest execute_test '
'--workload=nyc_taxis --test-mode --pipeline=benchmark-only '
'--workload=nyc_taxis --pipeline=benchmark-only '
'--target-hosts=abc.com --client-options="use_ssl:true,'
'verify_certs:false,basic_auth_user:\'admin\',basic_auth_password:\'admin\'"')

Expand All @@ -50,7 +50,7 @@ def test_execute_default_with_optional_args(self) -> None:
self.assertEqual(self.benchmark_test_suite.command, 'docker run -v /home/test/benchmark.ini:'
'/opensearch-benchmark/.benchmark/benchmark.ini '
'opensearchproject/opensearch-benchmark:latest execute_test '
'--workload=nyc_taxis --test-mode '
'--workload=nyc_taxis '
'--pipeline=benchmark-only --target-hosts=abc.com '
'--workload-params "number_of_replicas:1" '
'--user-tag="key1:value1,key2:value2"')