-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fixing not correct path in Readme #3506
[Bug] Fixing not correct path in Readme #3506
Conversation
Signed-off-by: Tokesh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3506 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 181 181
Lines 5340 5340
=======================================
Hits 4868 4868
Misses 472 472 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tokesh.
Add a comment to this one.
docker/README.md
Outdated
@@ -11,7 +11,7 @@ We build, assemble, and test our artifacts on docker containers. All of our pipe | |||
To build the docker image for either x64 or arm64, run the below command on a x64 or arm64 host respectively within the `opensearch-build/docker/ci` folder: | |||
|
|||
```bash | |||
docker build -f ./dockerfiles/integtest-runner.al2.dockerfile . -t <Docker Hub RepoName>/<Docker Image Name>:<Tag Name> | |||
bash build-image-single-arch.sh -r <Repo name> -v <Tag name> -f <Docker File Path> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add bash
specifically for the comment, just use ./
.
As explained in this post it is meant to use the build docker image scripts to build docker. Thanks. |
Ohh, I think I'm beginning to understand. |
Hi, As to how to use the image, those images are meant to be used with automation tools. You can use by yourself but we dont have guide on those, as everything is already taking care of by automation on Jenkins. See jenkins directory to find all the ways we are using the images. |
Signed-off-by: Tokesh <[email protected]>
@peterzhuamazon Hello! Thank you for a such detailed answer. I got it! |
Signed-off-by: Alen Abeshov <[email protected]>
Hello @peterzhuamazon! |
Co-authored-by: Alen Abeshov <[email protected]> Signed-off-by: Alen Abeshov <[email protected]>
2b0225b
to
b22fc9e
Compare
Hi @Tokesh @aabeshov I am ok with your change, but after reviewing a bit I think it is logical to move this This I will move it and merge this PR, thanks. |
…i directory Signed-off-by: Peter Zhu <[email protected]>
Description
First of all, './dockerfiles/integtest-runner.al2.dockerfile' this file does not exist. So we should replace it by '<Docker file path' anyway
In the readme, we say that we are launching on one of the platforms('either x64 or arm64'), that is, the single arch. So here probably its more suitable to use 'bash build-image-single-arch.sh' instead of 'docker-build'?
I think current Readme not newbie-friendly, so i tried to change it. I hope i understand all differences well (between single arch and multi-arch and etc).
I'm ready to hear all your feedback and change my mind in case of mistakes! I'm still a beginner, but I'm trying to improve the problems that I have myself
Issues Resolved
[#3458]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.