Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken manifest workflow #3609

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Jun 8, 2023

Description

Fix broken manifest workflow: https://build.ci.opensearch.org/job/manifest-update/49/console
and modify the code to update the osd-increment-plugin-versions.yml workflow with new branch entry.

Issues Resolved

#3610

Test on local

Updated the workflow files


Adding 2.9 to /usr/share/opensearch/git/opensearch-build/.github/workflows/os-increment-plugin-versions.yml
2023-06-08 21:48:16 INFO     Added new version to the version increment workflow
Adding 2.9 to /usr/share/opensearch/git/opensearch-build/.github/workflows/osd-increment-plugin-versions.yml
2023-06-08 21:48:16 INFO     Added new version to the version increment workflow

git status: Added new manifests


# On branch main
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   .github/workflows/os-increment-plugin-versions.yml
#	modified:   .github/workflows/osd-increment-plugin-versions.yml
#	modified:   jenkins/check-for-build.jenkinsfile
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#	manifests/2.8.1/
#	manifests/2.9.0/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #3609 (6d95744) into main (35398b9) will decrease coverage by 0.02%.
The diff coverage is 19.23%.

@@            Coverage Diff             @@
##             main    #3609      +/-   ##
==========================================
- Coverage   91.49%   91.48%   -0.02%     
==========================================
  Files         181      181              
  Lines        5376     5380       +4     
==========================================
+ Hits         4919     4922       +3     
- Misses        457      458       +1     
Impacted Files Coverage Δ
src/manifests_workflow/input_manifests.py 83.44% <19.23%> (-0.23%) ⬇️

@rishabh6788
Copy link
Collaborator

Please replace print with logging if required.

@prudhvigodithi prudhvigodithi force-pushed the main branch 3 times, most recently from f74e9c7 to f2f77d1 Compare June 8, 2023 23:30
Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi prudhvigodithi merged commit d5a6ae1 into opensearch-project:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants