-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows Container] Switch windows docker jdk back to temurin/openjdk mix #3946
Merged
peterzhuamazon
merged 1 commit into
opensearch-project:main
from
peterzhuamazon:docker-windows-switch-jdk-again-mix
Aug 31, 2023
Merged
[Windows Container] Switch windows docker jdk back to temurin/openjdk mix #3946
peterzhuamazon
merged 1 commit into
opensearch-project:main
from
peterzhuamazon:docker-windows-switch-jdk-again-mix
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
New Enhancement
release
cicd
docker
windows
jenkins
Jenkins related issue
v2.10.0
labels
Aug 31, 2023
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
August 31, 2023 16:54
This was referenced Aug 31, 2023
jordarlu
approved these changes
Aug 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #3946 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 187 187
Lines 5667 5667
=======================================
Hits 5217 5217
Misses 450 450 |
reta
reviewed
Aug 31, 2023
$jdkVersionList = "openjdk8-redhat JAVA8_HOME", "openjdk11 JAVA11_HOME", "openjdk14 JAVA14_HOME", "openjdk17 JAVA17_HOME", "openjdk19 JAVA19_HOME", "openjdk20 JAVA20_HOME" | ||
# As of now we will mix temurin and openjdk as temurin for production has support policies for fixes and patches | ||
# We need to make sure we do not mis-install temurin and openjdk with the same version or the distribution build code will have issues | ||
$jdkVersionList = "temurin8-jdk JAVA8_HOME", "temurin11-jdk JAVA11_HOME", "openjdk14 JAVA14_HOME", "temurin17-jdk JAVA17_HOME", "temurin19-jdk JAVA19_HOME", "openjdk20 JAVA20_HOME" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
peterzhuamazon
changed the title
Switch windows docker jdk back to temurin/openjdk mix
[Windows Container] Switch windows docker jdk back to temurin/openjdk mix
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cicd
distinguished-contributor
docker
enhancement
New Enhancement
jenkins
Jenkins related issue
release
v2.10.0
windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Windows Container] Switch windows docker jdk back to temurin/openjdk mix
Issues Resolved
opensearch-project/opensearch-ci#281
#3743
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.