Fix remote-store parameters. #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Singh <[email protected]>
rishabh6788
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
jordarlu
approved these changes
Aug 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #3949 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 187 187
Lines 5669 5669
=======================================
Hits 5219 5219
Misses 450 450 |
|
@rishabh6788 The bulk size is meant exclusively for the http logs workload. Request you to please revert this PR which removes the bulk size configuration. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix remote-store parameters.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.